1774297 - moz-phab submit doesn't allow uploading rebased change sets with r+ stamped by obsolete users

Status: NEW

(Conduit :: moz-phab, enhancement, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

I did rebase https://phabricator.services.mozilla.com/D95485 locally, and tried to submit but it fails with an error "User mats is disabled".

It would be nice to be able to uploaded even if the user is disabled but it's already stamped r+.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

A workaround (actually it's dholbert's idea).

1. use --wip to upload the rebased version
2. choose "Request Review" action on the phab site to remove "changes planned" phase

Comment 2

[Connor Sheehan [:sheehan]]

I think if you edit the commit message to remove r=mats it should allow you to submit. As long as you don't remove the Differential Revision: <url> line from the commit message it will tag against the same revision and should leave the disabled r+ on the revision. I haven't tested this but this is my understanding of how Phabricator works.

We could potentially try re-submitting without the disabled user as part of the Phabricator transaction if we hit this error, and log a warning so the user is aware of the issue. This is a pretty uncommon edge case though and it's likely a low priority fix.