1774304 - Assert failure in SWGL when enabling gfx.webrender.debug.render-targets in about:config (also causing crash on startup afterwards)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Ashley Hale [:ahale]]

WebRender (Software) mode calls SWGL BlitFramebuffer with format conversions it doesn't support when render-targets debugging is enabled (gfx.webrender.debug.render-targets) - GL_RED textures I believe.

Assert false at: https://searchfox.org/mozilla-central/rev/170f06a720ddabee44c728b05ad30b18b066acca/gfx/wr/swgl/src/composite.h#331

Comment 1

[Lee Salzman [:lsalzman]]

Do you have a more complete stack trace or a crash report here? It might help with tracking this down.

Comment 2

[Ashley Hale [:ahale]]

Attachment: Thread backtrace

Repro steps:
* gfx.webrender.all = true
* gfx.webrender.software = true
* gfx.webrender.debug.render-targets = true

Console output:

firefox: src/composite.h:331: void BlitFramebuffer(GLint, GLint, GLint, GLint, GLint, GLint, GLint, GLint, GLbitfield, GLenum): Assertion `false' failed.

Program /home/ahale/moz/mozilla-unified/obj-x86_64-pc-linux-gnu/dist/bin/firefox (pid = 594) received signal 6.
Stack:
#01: ???[/home/ahale/moz/mozilla-unified/obj-x86_64-pc-linux-gnu/dist/bin/libxul.so +0x9bf506e]
#02: ???[/lib/x86_64-linux-gnu/libc.so.6 +0x42520]
#03: pthread_kill[/lib/x86_64-linux-gnu/libc.so.6 +0x96a7c]
#04: raise[/lib/x86_64-linux-gnu/libc.so.6 +0x42476]
#05: abort[/lib/x86_64-linux-gnu/libc.so.6 +0x287f3]
#06: ???[/lib/x86_64-linux-gnu/libc.so.6 +0x2871b]
#07: ???[/lib/x86_64-linux-gnu/libc.so.6 +0x39e96]
#08: ???[/home/ahale/moz/mozilla-unified/obj-x86_64-pc-linux-gnu/dist/bin/libxul.so +0xb8486f5]
#09: _$LT$swgl..swgl_fns..Context$u20$as$u20$gleam..gl..Gl$GT$::blit_framebuffer::h3c16e51d9bf25ce2[/home/ahale/moz/mozilla-unified/obj-x86_64-pc-linux-gnu/dist/bin/libxul.so +0xb83c896]
#10: ???[/home/ahale/moz/mozilla-unified/obj-x86_64-pc-linux-gnu/dist/bin/libxul.so +0xb6b7201]
Sleeping for 300 seconds.
Type 'gdb /home/ahale/moz/mozilla-unified/obj-x86_64-pc-linux-gnu/dist/bin/firefox 594' to attach your debugger to this thread.

Comment 3

[Ashley Hale [:ahale]]

Attachment: Thread backtrace

Comment 4

[Lee Salzman [:lsalzman]]

Attachment: Bug 1774304 - Support simple format conversions when blitting. r?jrmuizel

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d6e43d44800
Support simple format conversions when blitting. r=jrmuizel

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7d6e43d44800