1774336 - Make FileInfoManagerGuard's default constructor public for C++20

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect, P3)

Description

[Chris Peterson [:cpeterson]]

C++20 changes to direct initialization with initializer lists make FileInfoManagerGuard's default constructor inaccessible.

https://en.cppreference.com/w/cpp/language/direct_initialization

Example code:

class C {
  C() {}
};

class D {
  D() = default;  // like FileInfoManagerGuard
};

int main() {
  C c{};  // error in C++17 and C++20
  D d1;   // error in C++17 and C++20
  D d2{}; // OK in C++17, error in C++20. This is how FileInfoManagerGuard objects are initialized.
  return 0;
}

Comment 1

[Chris Peterson [:cpeterson]]

Example C++20 error in clang and gcc:

dom/indexedDB/ActorsParent.cpp:12131:21: error: calling a private constructor of class 'mozilla::dom::indexedDB::FileInfoManager<mozilla::dom::indexedDB::DatabaseFileManager>::FileInfoManagerGuard'
                    FileInfoManagerGuard{}, SafeRefPtrFromThis(), id,
                    ^
dom/indexedDB/FileInfoManager.h:92:5: note: implicitly declared private here
    FileInfoManagerGuard() = default;
    ^

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Bug 1774336 - Make FileInfoManagerGuard's default constructor public for C++20. r?#dom-storage-reviewers

C++20 changes to direct initialization with initializer lists make FileInfoManagerGuard's default constructor inaccessible.

https://en.cppreference.com/w/cpp/language/direct_initialization

dom/indexedDB/ActorsParent.cpp:12131:21: error: calling a private constructor of class 'mozilla::dom::indexedDB::FileInfoManager<mozilla::dom::indexedDB::DatabaseFileManager>::FileInfoManagerGuard'
FileInfoManagerGuard{}, SafeRefPtrFromThis(), id,
^
dom/indexedDB/FileInfoManager.h:92:5: note: implicitly declared private here
FileInfoManagerGuard() = default;
^

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3875c2b3246
Make FileInfoManagerGuard's default constructor public for C++20. r=saschanaz

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c3875c2b3246