Closed Bug 1774419 Opened 2 years ago Closed 2 years ago

Perma browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - chrome://global/skin/icons/loading-dial.svg is unused outside of nightly

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
103 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- unaffected
firefox101 --- unaffected
firefox102 --- unaffected
firefox103 + verified

People

(Reporter: CrissCozmuta, Assigned: Gijs)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [fidefe-2022-mr1-firefox-view])

Attachments

(1 file)

Bug 1774419 - fix loading-dial.svg to not ship outside of Nightly, r?sfoster,dao
48 bytes, text/x-phabricator-request
Details | Review

Central-as-beta simulation
How to run these simulations

Failure log

Failure line:
TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 1, expected +0
TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://global/skin/icons/loading-dial.svg -

task 2022-06-15T12:33:02.664Z] 12:33:02     INFO - TEST-START | browser/base/content/test/static/browser_all_files_referenced.js
[task 2022-06-15T12:33:03.550Z] 12:33:03     INFO - GECKO(9912) | JavaScript error: resource://gre/modules/XULStore.jsm, line 68: Error: Can't find profile directory.
[task 2022-06-15T12:33:08.089Z] 12:33:08     INFO - TEST-INFO | started process screentopng
[task 2022-06-15T12:33:08.393Z] 12:33:08     INFO - TEST-INFO | screentopng: exit 0
[task 2022-06-15T12:33:08.394Z] 12:33:08     INFO - Buffered messages logged at 12:33:02
[task 2022-06-15T12:33:08.394Z] 12:33:08     INFO - Entering test bound checkAllTheFiles
[task 2022-06-15T12:33:08.395Z] 12:33:08     INFO - Buffered messages logged at 12:33:03
[task 2022-06-15T12:33:08.395Z] 12:33:08     INFO - Console message: [JavaScript Error: "Error: Can't find profile directory." {file: "resource://gre/modules/XULStore.jsm" line: 68}]
[task 2022-06-15T12:33:08.395Z] 12:33:08     INFO - load@resource://gre/modules/XULStore.jsm:68:15
[task 2022-06-15T12:33:08.396Z] 12:33:08     INFO - XULStore@resource://gre/modules/XULStore.jsm:26:10
[task 2022-06-15T12:33:08.396Z] 12:33:08     INFO - 
[task 2022-06-15T12:33:08.396Z] 12:33:08     INFO - Buffered messages logged at 12:33:08
[task 2022-06-15T12:33:08.396Z] 12:33:08     INFO - indirectly whitelisted file: chrome://remote/content/marionette/test_dialog.dtd used from chrome://remote/content/marionette/test_dialog.xhtml
[task 2022-06-15T12:33:08.396Z] 12:33:08     INFO - indirectly whitelisted file: chrome://global-platform/locale/intl.properties used from resource://gre/greprefs.js
[task 2022-06-15T12:33:08.396Z] 12:33:08     INFO - indirectly whitelisted file: resource://services-sync/addonutils.js used from resource://services-sync/engines/addons.js
[task 2022-06-15T12:33:08.396Z] 12:33:08     INFO - indirectly whitelisted file: resource://services-sync/bridged_engine.js used from resource://services-sync/engines/extension-storage.js
[task 2022-06-15T12:33:08.397Z] 12:33:08     INFO - indirectly whitelisted file: chrome://pippki/content/resetpassword.js used from chrome://pippki/content/resetpassword.xhtml
[task 2022-06-15T12:33:08.398Z] 12:33:08     INFO - indirectly whitelisted file: chrome://global/content/remote-test-ipc.js used from chrome://global/content/test-ipc.xhtml
[task 2022-06-15T12:33:08.399Z] 12:33:08     INFO - indirectly whitelisted file: resource://services-sync/addonsreconciler.js used from resource://services-sync/engines/addons.js
[task 2022-06-15T12:33:08.401Z] 12:33:08     INFO - indirectly whitelisted file: resource://services-sync/collection_validator.js used from resource://services-sync/engines/addons.js,resource://services-sync/engines/forms.js,resource://services-sync/engines/passwords.js
[task 2022-06-15T12:33:08.402Z] 12:33:08     INFO - indirectly whitelisted file: resource://services-sync/bookmark_validator.js used from resource://services-sync/engines/bookmarks.js
[task 2022-06-15T12:33:08.402Z] 12:33:08     INFO - indirectly whitelisted file: chrome://pippki/content/load_device.js used from chrome://pippki/content/load_device.xhtml
[task 2022-06-15T12:33:08.403Z] 12:33:08     INFO - indirectly whitelisted file: resource://gre/modules/Http.jsm used from resource://app/modules/translation/GoogleTranslator.jsm,resource://app/modules/translation/YandexTranslator.jsm,resource://app/modules/translation/BingTranslator.jsm
[task 2022-06-15T12:33:08.404Z] 12:33:08     INFO - indirectly whitelisted file: resource://gre/modules/SyncedBookmarksMirror.jsm used from resource://services-sync/engines/bookmarks.js
[task 2022-06-15T12:33:08.409Z] 12:33:08     INFO - indirectly whitelisted file: chrome://remote/content/marionette/test2.xhtml used from chrome://remote/content/marionette/test.xhtml,chrome://remote/content/marionette/test_nested_iframe.xhtml
[task 2022-06-15T12:33:08.409Z] 12:33:08     INFO - indirectly whitelisted file: chrome://remote/content/marionette/test_nested_iframe.xhtml used from chrome://remote/content/marionette/test.xhtml
[task 2022-06-15T12:33:08.410Z] 12:33:08     INFO - indirectly whitelisted file: resource://app/modules/SnapshotScorer.jsm used from 
[task 2022-06-15T12:33:08.410Z] 12:33:08     INFO - Buffered messages finished
[task 2022-06-15T12:33:08.411Z] 12:33:08     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 1, expected +0
[task 2022-06-15T12:33:08.412Z] 12:33:08     INFO - Stack trace:
[task 2022-06-15T12:33:08.412Z] 12:33:08     INFO - chrome://mochikit/content/browser-test.js:test_is:1429
[task 2022-06-15T12:33:08.412Z] 12:33:08     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:1037
[task 2022-06-15T12:33:08.412Z] 12:33:08     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-06-15T12:33:08.413Z] 12:33:08     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://global/skin/icons/loading-dial.svg - 
[task 2022-06-15T12:33:08.413Z] 12:33:08     INFO - Stack trace:
[task 2022-06-15T12:33:08.413Z] 12:33:08     INFO - chrome://mochikit/content/browser-test.js:test_ok:1401
[task 2022-06-15T12:33:08.413Z] 12:33:08     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:1041
[task 2022-06-15T12:33:08.414Z] 12:33:08     INFO - ignored unused whitelist entry: resource://app/blocklist.xml
[task 2022-06-15T12:33:08.414Z] 12:33:08     INFO - ignored unused whitelist entry: resource://gre/gmp-clearkey/0.1/manifest.json
[task 2022-06-15T12:33:08.415Z] 12:33:08     INFO - ignored unused whitelist entry: resource://gre/res/test.properties
[task 2022-06-15T12:33:08.415Z] 12:33:08     INFO - missing file: chrome://browser/content/firefoxview.html
[task 2022-06-15T12:33:08.416Z] 12:33:08     INFO - missing file: chrome://aboutsync/content/AboutSyncRedirector.js
[task 2022-06-15T12:33:08.417Z] 12:33:08     INFO - missing file: resource://search-extensions/yandex/__MSG_extensionIcon__
<...>
[task 2022-06-15T12:33:08.817Z] 12:33:08     INFO - missing file: chrome://report-site-issue/locale/webcompat.properties referenced from jar:file:///builds/worker/workspace/build/application/firefox/browser/features/webcompat-reporter@mozilla.org.xpi!/experimentalAPIs/l10n.js
[task 2022-06-15T12:33:08.818Z] 12:33:08     INFO - missing file: resource://app/localization/en-US/toolkit/payments/payments.ftl referenced from chrome://formautofill/content/manageCreditCards.xhtml
[task 2022-06-15T12:33:08.819Z] 12:33:08     INFO - missing file: resource://screenshots-addon/ referenced from jar:file:///builds/worker/workspace/build/application/firefox/browser/features/screenshots@mozilla.org.xpi!/background/senderror.js
[task 2022-06-15T12:33:08.820Z] 12:33:08     INFO - missing file: resource://app/localization/en-US/toolkit/about/aboutCompat.ftl referenced from jar:file:///builds/worker/workspace/build/application/firefox/browser/features/webcompat@mozilla.org.xpi!/about-compat/aboutCompat.html
[task 2022-06-15T12:33:08.820Z] 12:33:08     INFO - Leaving test bound checkAllTheFiles
[task 2022-06-15T12:33:08.821Z] 12:33:08     INFO - Console message: No chrome package registered for chrome://aboutsync/content/AboutSyncRedirector.js
[task 2022-06-15T12:33:08.822Z] 12:33:08     INFO - Console message: No chrome package registered for chrome://geckoview/skin/images/accessiblecaret-normal.svg
[task 2022-06-15T12:33:08.822Z] 12:33:08     INFO - Console message: No chrome package registered for chrome://geckoview/skin/images/accessiblecaret-tilt-left.svg
[task 2022-06-15T12:33:08.823Z] 12:33:08     INFO - Console message: No chrome package registered for chrome://geckoview/skin/images/accessiblecaret-tilt-right.svg
[task 2022-06-15T12:33:08.824Z] 12:33:08     INFO - Console message: No chrome package registered for chrome://geckoview/content/geckoview.xhtml
[task 2022-06-15T12:33:08.824Z] 12:33:08     INFO - Console message: No chrome package registered for chrome://help/content/help.js
[task 2022-06-15T12:33:08.825Z] 12:33:08     INFO - Console message: No chrome package registered for chrome://report-site-issue/locale/webcompat.properties
[task 2022-06-15T12:33:08.826Z] 12:33:08     INFO - GECKO(9912) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2022-06-15T12:33:08.826Z] 12:33:08     INFO - GECKO(9912) | MEMORY STAT | vsize 11585MB | residentFast 745MB | heapAllocated 552MB
[task 2022-06-15T12:33:08.827Z] 12:33:08     INFO - TEST-OK | browser/base/content/test/static/browser_all_files_referenced.js | took 5954ms
[task 2022-06-15T12:33:08.827Z] 12:33:08     INFO - checking window state
[task 2022-06-15T12:33:08.828Z] 12:33:08     INFO - TEST-START | browser/base/content/test/static/browser_misused_characters_in_strings.js

Hi Sam,
Can you please take a look at this ?
It looks like it was caused by the latest changes in Bug 1768681.

Thank you!

Flags: needinfo?(sfoster)

I can take this.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(sfoster)
Summary: Perma browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 1, expected +0 when when Gecko 103 merges to Beta on 2022-06-27 → Perma browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - chrome://global/skin/icons/loading-dial.svg is unused outside of nightly
tracking-firefox103: + → ?
Keywords: regression
Whiteboard: [fidefe-2022-mr1-firefox-view]
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/80a781e79bd7
fix loading-dial.svg to not ship outside of Nightly, r=sfoster

The patch seems to be working in today's beta-sim

https://hg.mozilla.org/mozilla-central/rev/80a781e79bd7

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox103: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
Status: RESOLVED → VERIFIED
status-firefox103: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: