Show the commits information in more visible place
Categories
(Conduit :: Phabricator, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: arai, Unassigned)
References
Details
(Keywords: conduit-triaged)
If the original author of the local patch is different from the user who submits the patch, the original author's information is stored in the phabricator revision and used when landing the patch, but it's hidden in the phabricator revision page in the "Commits" tab in "Revision Contents".
I don't think it's the right place to show such important information.
it should be moved or copied to "Details" box or somewhere.
|
Reporter | |
Comment 1•3 years ago
|
||
Note: there can be multiple commits associated with single phabricator revision, but that feature is not much used,
so we can show single author by default, and handle multiple authors (multiple commits) case as an exception.
|
|
Reporter | |
Comment 2•3 years ago
|
||
bug 1626326 is going to remove some unused UI elements, and we'll have more places to show necessary information.
|
||
Comment 3•3 years ago
|
||
It might make sense to move the entire section (files/history/commits/stack) to a more prominent spot (e.g. above the comments/under diff details) but I don't know if it's necessary to expose any of the information inside of those individual tabs elsewhere though.
If the original author of the local patch is different from the user who submits the patch, the original author's information is stored in the phabricator revision and used when landing the patch
As an aside, Lando has a method that determines the most common author in a given set of diffs, and that's what's used as the author ultimately when landing the revision.
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
||
Comment 4•5 months ago
|
||
Could we also include some basic validation that the author information is accurate/reasonable? Doing so in Phabricator would be a prerequisite for enforcing it somewhere else (if we ever can or want to do so - I have no idea whether we do).
I recall multiple instances of incorrect authorship, e.g.
-
revert created at https://bugzilla.mozilla.org/show_bug.cgi?id=1987407#c3
The generated commit had a wrong email (the domain is missing one "l"): https://github.com/mozilla-firefox/firefox/commit/30421317e6a9.patch
(this was probably generated outside of Phabricator, but still shows that the email address field of commit message is presently very unreliable) -
the patch had a new author (vhilla), but was still attributed to the original author (hsivonen): https://github.com/mozilla-firefox/firefox/commit/39a8a4171bb2
Description
•