1774505 - Support null timeline for printing

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, defect, P3)

Description

[Boris Chiou [:boris]]

Obviously, we pass these 2 tests ([1] and [2]) by accident because

1. We are always using document timeline for printing.
2. We use SpecifiedTiming() when cloning KeyframeEffect but this function may return a special timing for scroll-timeline. I believe we don't want to use it to replace the original mTiming when cloning a new AnimationEffect (because this special version represents the resolved timing for scroll timeline.)

So we have to rewrite Element::CloneAnimationsFrom and Animation::ClonePausedAnimation for different types of animation timeline.

[1] https://searchfox.org/mozilla-central/source/testing/web-platform/tests/scroll-animations/css/at-scroll-timeline-default-descriptors-print.tentative.html
[2] https://searchfox.org/mozilla-central/source/testing/web-platform/tests/scroll-animations/css/at-scroll-timeline-default-descriptors-iframe-print.html

Comment 1

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Based on D149683 I guess this should include https://searchfox.org/mozilla-central/source/testing/web-platform/tests/scroll-animations/css/at-scroll-timeline-specified-scroller-print.html too.

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1774505 - Preserve the progress of null timeline for print.

In order to avoid cloning and manipulate the scroll timeline objects in
the cloned document (because we may have issues to retrieve the scroll offsets
in the print document and its iframes), so we always use the document
timeline of the cloned document, and clone the paused animation with the
preserved progress.

Also, I rename the test file because "default" doesn't make sense right
now.

Note: animation-timeline-scroll-functional-notation-print.html has one
assertion which is not related to animation. So we don't fix it for now.

Comment 3

[Boris Chiou [:boris]]

Attachment: Bug 1774505 - Move tests of printing documents into an independent folder.

There is still a spec issue about printing for scroll animations,
https://github.com/w3c/csswg-drafts/issues/8226, so I think moving all of
them into a separate folder makes us easier to address.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af9f16e795fc
Preserve the progress of null timeline for print. r=hiro
https://hg.mozilla.org/integration/autoland/rev/9199e7f4539e
Move tests of printing documents into an independent folder. r=hiro

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37539 for changes under testing/web-platform/tests

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/af9f16e795fc
https://hg.mozilla.org/mozilla-central/rev/9199e7f4539e

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot