Stop removing query parameters in SourceTree and Tab headers
Categories
(DevTools :: Debugger, enhancement)
Tracking
(firefox103 fixed)
| Tracking | Status | |
|---|---|---|
| firefox103 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 2 open bugs)
Details
Attachments
(3 files)
bug 1774349 and bug 1774346 highlight the existing issues and complexity of the current implementation which tries to remove the query parameters from the source tree and tab headers.
This is a known source of performance issue, the behavior is not consistant between the two UI bits and it adds a fair amount of complexity just for this one feature.
Here is a test page highlighting all the various behaviors:
http://techno-barje.fr/fission/query-params/
Opening sources from the source tree, you can see differences appear between source tree and tab headers.
The plan here would be to remove all logic removing query parameters, while we would keep removing hash string. While doing so, we should ensure that the source filename is still readable if long query strings are used.
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 4•2 years ago
|
||
|
|
Assignee | |
Comment 5•2 years ago
|
||
Surprisingly, DAMP reports no improvement:
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=3e32d966982c3c72c98bfb8ad3e9b57d97564fdd&originalSignature=4081483&newSignature=4081483&framework=12&originalRevision=b6f21836ba06f8dd4390bd7d1c874d3bb7840bfb&page=1&showOnlyComparable=1&filter=jsdebugger
Whereas we are removing lots of code that appears in profile records, especially the getHasSiblingOfSameName selector.
|
|
||
Updated•2 years ago
|
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2e547daa8555 [devtools] Stop hiding query parameters in the SourceTree. r=bomsy https://hg.mozilla.org/integration/autoland/rev/4d0fd79de60e [devtools] Stop hiding query parameters in Tab components. r=bomsy https://hg.mozilla.org/integration/autoland/rev/b142d6884a32 [devtools] Remove plain url computation. r=bomsy
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2e547daa8555
https://hg.mozilla.org/mozilla-central/rev/4d0fd79de60e
https://hg.mozilla.org/mozilla-central/rev/b142d6884a32
Description
•