Closed Bug 1774628 Opened 2 years ago Closed 8 months ago

Re-enable support for Windows.Graphics.Capture APIs in libwebrtc


(Core :: WebRTC, task, P2)




119 Branch
Tracking Status
firefox119 --- fixed


(Reporter: mjf, Assigned: mjf)




(2 files)

Upstream commit 78f04d8f4df9701d8307fb6cbf6e1ff0a2646f05 enables flag RTC_ENABLE_WIN_WGC to support Windows.Graphics.Capture APIs, but that requires Win10 SDK v10.0.17763 (preferably v10.0.19041).

Note: I don't see a build failure on my local Win box, so this may only be an issue on CI machines.

The code I'm adding in bug 1774844 also needs SDK v10.0.17763 or later. For now I'm adding a workaroud in the patch with an #ifndef NTDDI_WIN10_RS5 block, that would be nice to remove.

Firefox builds fine with the latest VC2022 and Win11 SDK releases. I wonder if we should just switch to the latest available for better future proofing.

Flags: needinfo?(mh+mozilla)

It's double sided. If we use the latest, then we may end up breaking older versions. There's probably some middle ground to find. We'll probably want to bump the minimum version of UCRT we want in build/moz.configure/windows.configure.

New versions are now easily serviceable, by creating yaml files in build/vs/ and adding corresponding toolchains in taskcluster/ci/toolchain/misc.yml. We already have vs2019 there, BTW.

Flags: needinfo?(mh+mozilla)
See Also: → 1792086

This would be useful for bug 1803334 as well, I'm not sure of the exact version required but 10.0.19041.0 works.

See Also: → 1808667

FYI, as of bug 1832467, we're using VS2019 w/ the 10.0.19041 SDK now.

Summary: Update Win10 SDK to at least v10.0.17763 to support Windows.Graphics.Capture APIs in libwebrtc → Re-enable support for Windows.Graphics.Capture APIs in libwebrtc
Assignee: nobody → mfroman
Priority: -- → P2

Here is an experimental try build: I'll do a full try run with a more official patch soon.

No longer blocks: 1803334
Pushed by
re-enable support for Windows.Graphics.Capture APIs in libwebrtc. r=pehrsons,webrtc-reviewers
re-enable support for Windows.Graphics.Capture APIs in libwebrtc. - file updates. r=pehrsons,webrtc-reviewers
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
See Also: 1792086
Depends on: 1832467
You need to log in before you can comment on or make changes to this bug.