Re-enable support for Windows.Graphics.Capture APIs in libwebrtc
Categories
(Core :: WebRTC, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox119 | --- | fixed |
People
(Reporter: mjf, Assigned: mjf)
References
Details
Attachments
(2 files)
Upstream commit 78f04d8f4df9701d8307fb6cbf6e1ff0a2646f05 enables flag RTC_ENABLE_WIN_WGC to support Windows.Graphics.Capture APIs, but that requires Win10 SDK v10.0.17763 (preferably v10.0.19041).
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 1•2 years ago
|
||
Note: I don't see a build failure on my local Win box, so this may only be an issue on CI machines.
|
||
Comment 2•2 years ago
|
||
The code I'm adding in bug 1774844 also needs SDK v10.0.17763 or later. For now I'm adding a workaroud in the patch with an #ifndef NTDDI_WIN10_RS5 block, that would be nice to remove.
|
||
Comment 3•2 years ago
|
||
Firefox builds fine with the latest VC2022 and Win11 SDK releases. I wonder if we should just switch to the latest available for better future proofing.
|
||
Comment 4•2 years ago
|
||
It's double sided. If we use the latest, then we may end up breaking older versions. There's probably some middle ground to find. We'll probably want to bump the minimum version of UCRT we want in build/moz.configure/windows.configure.
New versions are now easily serviceable, by creating yaml files in build/vs/ and adding corresponding toolchains in taskcluster/ci/toolchain/misc.yml. We already have vs2019 there, BTW.
|
||
Comment 5•1 year ago
|
||
This would be useful for bug 1803334 as well, I'm not sure of the exact version required but 10.0.19041.0 works.
|
|
||
Comment 6•10 months ago
|
||
FYI, as of bug 1832467, we're using VS2019 w/ the 10.0.19041 SDK now.
|
|
Assignee | |
Updated•8 months ago
|
|
|
Assignee | |
Updated•8 months ago
|
|
|
Assignee | |
Comment 7•8 months ago
|
||
Here is an experimental try build: https://treeherder.mozilla.org/jobs?repo=try&revision=04ef5f04085f9baa3c15c0c0626733f781745e60. I'll do a full try run with a more official patch soon.
|
|
Assignee | |
Comment 8•8 months ago
|
||
|
|
Assignee | |
Comment 9•8 months ago
|
||
Depends on D186862
|
|
Assignee | |
Comment 10•8 months ago
|
||
|
||
Comment 11•8 months ago
|
||
Pushed by mfroman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/08567f4539a1 re-enable support for Windows.Graphics.Capture APIs in libwebrtc. r=pehrsons,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/6d56df5a9afd re-enable support for Windows.Graphics.Capture APIs in libwebrtc. - moz.build file updates. r=pehrsons,webrtc-reviewers
|
||
Comment 12•8 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/08567f4539a1
https://hg.mozilla.org/mozilla-central/rev/6d56df5a9afd
Description
•