automate openh264 notarization
Categories
(Release Engineering :: Release Automation: Signing, task)
Tracking
(firefox105 fixed)
| Tracking | Status | |
|---|---|---|
| firefox105 | --- | fixed |
People
(Reporter: mozilla, Assigned: gbrown)
References
Details
Attachments
(3 files)
|
Reporter | |
Comment 1•2 years ago
|
||
We also have to fix builds: https://treeherder.mozilla.org/jobs?repo=try&revision=111139712c46b0a9f78f2d437e6109382f64d045
(win64 is the only platform build to go green when I s,python,python3, in gittool.py to fix git clone bustage on all platforms)
|
Assignee | |
Comment 2•2 years ago
|
||
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 3•2 years ago
|
||
:jrmuizel - I'm seeing build errors on win64-aarch and win-x86 (only); are those expected by any chance? Any advice?
https://treeherder.mozilla.org/jobs?repo=try&revision=5d595590d1a9dccf9dc81fc126781d20df83810c
|
||
Comment 4•2 years ago
|
||
It looks like the build errors are caused by CFLAGS not being set by the makefile. I don't understand why this would be happening.
|
||
Comment 5•2 years ago
|
||
I guess this might override the CFLAGS from the makefile: https://searchfox.org/mozilla-central/source/testing/mozharness/scripts/openh264_build.py#226-230?
|
|
||
Comment 6•2 years ago
|
||
Shouldn't that CFLAGS just be the initial value that gets appended to here: https://github.com/cisco/openh264/blob/2e637867315ffeda3cd8970825ec86acc3fc4a30/build/msvc-common.mk#L32
|
||
Updated•2 years ago
|
|
|
Reporter | |
Updated•2 years ago
|
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b156dc2e7afe Fix openh264 builds; r=releng-reviewers,aki
|
||
Comment 8•2 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 9•2 years ago
|
||
I think the Windows builds are OK now, but I'm happy to modify if anyone has ideas for improvement.
|
|
||
Comment 10•2 years ago
|
||
Looks like the reason that CFLAGS is being overwritten is by design: https://www.gnu.org/software/make/manual/make.html#Override-Directive
Instead of setting it using a command line argument we should use an environment variable.
|
|
Assignee | |
Comment 11•2 years ago
•
|
||
|
|
||
Comment 12•2 years ago
|
||
The CFLAGS thing needs fixing otherwise we'll be building Windows builds without optimization.
|
|
Assignee | |
Comment 13•2 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #12)
The CFLAGS thing needs fixing otherwise we'll be building Windows builds without optimization.
Thanks!
|
|
Assignee | |
Comment 14•2 years ago
|
||
By using environment variables, the earlier _HAS_EXCEPTIONS hack
can be removed.
|
|
Assignee | |
Updated•2 years ago
|
|
||
Comment 15•2 years ago
|
||
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/96db82c97618 Move Windows openh264 CFLAGS to env; r=aki
|
||
Comment 16•2 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 17•2 years ago
|
||
(In reply to Aki Sasaki [:aki] (he/him) (UTC-6) from comment #0)
Bonus points for also adding a way to easily trigger these, outside of add-new-jobs? Might be a simple action.
An action was added in bug 1513000; some of it remains: https://searchfox.org/mozilla-central/source/taskcluster/gecko_taskgraph/actions/openh264.py
|
|
Assignee | |
Comment 18•2 years ago
|
||
iscript changes deployed with https://github.com/mozilla-platform-ops/ronin_puppet/pull/405
|
|
Assignee | |
Comment 19•2 years ago
|
||
Start using the mac_notarize_single_file behavior for openh264 signing.
|
|
||
Comment 20•2 years ago
|
||
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/75285656feb8 Use notarization for openh264 signing; r=releng-reviewers,hneiva
|
||
Comment 21•2 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 22•2 years ago
|
||
Verified in https://firefox-ci-tc.services.mozilla.com/tasks/N4tBI5XqTtqQPkVax_LGfw
...
2022-07-29 13:12:14,013 - scriptworker_client.utils - INFO - Status Code: 0
2022-07-29 13:12:14,013 - scriptworker_client.utils - INFO - Status Message: Package Approved
2022-07-29 13:12:14,014 - scriptworker_client.utils - INFO - ['xcrun', 'altool', '--notarization-info', '669f40cf-03ee-405e-9e43-4b98decc0bfa', '-u', 'release_notarization@mozilla.com', '--password', '********'] in / exited 0
2022-07-29 13:12:14,015 - iscript.mac - INFO - /builds/scriptworker/artifacts/private/openh264/openh264-macosx64-2e1774ab6dc6c43debb0b5b628bdf122a391d521.zip notarized
2022-07-29 13:12:14,015 - iscript.mac - INFO - Done signing single files.
exit code: 0
Description
•