1774676 - "100%" text on the Zoom toolbarbutton is hard to read

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 698873

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:mconley, since you are the author of the regressor, bug 698873, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[Itiel]

Attachment: Bug 1774676 - Fix the "100%" zoom toolbarbutton text being hard to read r?mconley

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82e0c1d50d83
Fix the "100%" zoom toolbarbutton text being hard to read r=mconley

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/82e0c1d50d83

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 698873

Comment 7

[Monica Chiorean]

I tried to reproduce the issue on Win10 using build 103.0a1(20220609220048) and 103.0a1(16th of June) and checked Zoom options from toolbar. But I see no difference between the latest Beta 103.0b4 and the builds without the fix. Can you please provide more detailed steps? Thank you.

Comment 8

[Itiel]

(In reply to Monica Chiorean from comment #7)

I tried to reproduce the issue on Win10 using build 103.0a1(20220609220048) and 103.0a1(16th of June) and checked Zoom options from toolbar. But I see no difference between the latest Beta 103.0b4 and the builds without the fix. Can you please provide more detailed steps? Thank you.

1. Add the zoom controls to the toolbar
2. Be on any website with zoom level = 100%
3. On older builds, the 100% is not the same color as the + or - and looks faded. On latest Nightly all 3 should look the same

Comment 9

[Monica Chiorean]

I checked again on latest Nightly 104.0a1(20220705212856) / Beta103.0b5 builds and all 3 buttons look the same, but depending on the theme used they are a bit hard to view (see screenshot attached from Win10, but same experience is visible on Ubuntu20.4; theme used is 'Colour-Spectrum').

Comment 10

[Monica Chiorean]

Attachment: Screenshot.png

Comment 11

[Monica Chiorean]

Is behavior explained on comment9 and 9 correct?

Comment 12

[Itiel]

(In reply to Monica Chiorean from comment #11)

Is behavior explained on comment9 and 9 correct?

I think you're comparing Nightly with a build too old where the issue didn't occur. Can you re-test things with a build newer than 20220612?

Comment 13

[Monica Chiorean]

Attachment: Screenshot2.jpg

Indeed with a newer version the Zoom looks better.

Comment 14

[Monica Chiorean]

(In reply to Itiel from comment #12)

(In reply to Monica Chiorean from comment #11)

Is behavior explained on comment9 and 9 correct?

I think you're comparing Nightly with a build too old where the issue didn't occur. Can you re-test things with a build newer than 20220612?

For theme 'Colour-Spectrum' should I log a separate issue? Thank you.

Comment 15

[Itiel]

mconley, what do you think the desired outcome should be here? See the comparison in comment 10.
Before (on Windows), this took place:
https://searchfox.org/mozilla-central/rev/f41f31de675cc9ac0c17a7ad84c0b32cd08994c5/toolkit/themes/windows/global/toolbarbutton.css#55-57
but now that the toolbarbutton is disabled this doesn't happen when the page zoom is 100%.
This causes the toolbarbutton to toggle text-shadow back and forth when the zoom changes from 100% to a different value.
IMO this should be consistent regardless, and seeing the other (non-bookmarkitems) toolbarbuttons, I think the button should have no text-shadow.
(The toolbarbuttons should have a shadow or something because now their white color blends too well with the background, but that's a different issue)

WDYT?

Comment 16

[Mike Conley (:mconley) (:⚙️) (PTO July 21 - 25)]

Hi Itiel,

Sorry for the delay here. I agree that when in the toolbar, if the text has drop-shadow, we'll want to keep it even if the button is disabled.