1774750 - UpdateService references unknown property wasSilentlyRestarted

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Mark Banner (:standard8)]

Bug 1728653 replaced nsIAppStartup.wasSilentlyRestarted with nsIAppStartup.wasSilentlyStarted but missed replacing the case in UpdateServices.jsm (probably because it landed a few days after bug 1720742 landed which added the case).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1728653

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:dthayer, since you are the author of the regressor, bug 1728653, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1774750 - Fix wasSilentlyStarted typo in UpdateService.jsm r?standard8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/809b75d9b465
Fix wasSilentlyStarted typo in UpdateService.jsm r=application-update-reviewers,nalexander

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/809b75d9b465

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR102 approval when you get a chance.

Comment 7

[Alex Thayer [:alexical] (she/her)]

Comment on attachment 9281892 [details]
Bug 1774750 - Fix wasSilentlyStarted typo in UpdateService.jsm r?standard8

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: It's is simply an obvious code typo.
• User impact if declined: Possibly none? I don't actually see any evidence that this code path was ever hit. If it is hit, it would mean users would be randomly prompted with a permission dialogue when Firefox has all windows closed.
• Fix Landed on Version: 103
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It was a clear typo before, so the patch is clearly correct.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9281892 [details]
Bug 1774750 - Fix wasSilentlyStarted typo in UpdateService.jsm r?standard8

Approved for 102.1esr.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/e762190a44bc