1774765 - Add support for pager, fax, mobile, ... types for vCard telephone numbers in the edit UI

Status: VERIFIED FIXED

(Thunderbird :: Address Book, enhancement)

Description

[John Bieling (:TbSync)]

Attachment: contact.png

The edit UI only has "Home", "Work" and "None" in the dropdown type selector, but the overview UI correctly displays the additional type info.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1774765 - Add mobile, fax and pager types to Address Book card editor. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3b73aa35ddad
Add mobile, fax and pager types to Address Book card editor. r=#thunderbird-reviewers,aleca

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9282305 [details]
Bug 1774765 - Add mobile, fax and pager types to Address Book card editor. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): new Address Book
User impact if declined: can't make a phone number marked as mobile or fax
Testing completed (on c-c, etc.): landed last week
Risk to taking this patch (and alternatives if risky): no

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9282305 [details]
Bug 1774765 - Add mobile, fax and pager types to Address Book card editor. r=#thunderbird-reviewers

Wrong flag.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9282305 [details]
Bug 1774765 - Add mobile, fax and pager types to Address Book card editor. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102

Let's explicitly QA/test address book in RC2, to make sure there are no regressions or ill effects

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 102.0:
https://hg.mozilla.org/releases/comm-esr102/rev/63719672a977

Comment 7

[WaltS48 [:walts48]]

Verified testing the 102.0 rc and release on Windows and Fedora Linux

Comment 8

[Thomas D. (:thomas8)]

I have continuously tested the new AB before and after release and filed bugs against it.

Tried a fully filled contact card from TB 91 today and updated that to TB 102. Quite time-consuming...

• pager, fax, mobile etc. all migrated perfectly (this bug 1774765, VERIFIED FIXED)

More findings:

• web addresses without protocol like http:// not shown in display - odd. Also blocks saving other edits like name to the card - worse.
• Filed Bug 1779567 - Reversed order of primary street address and extended address after update to 102
• Birthday of 29 Feb (without year, from TB91) displays as 1 March. Also blocks saving other edits. Bug 1779100 territory.

Tested and same result for 102.0.2 (64-bit) and 104.0a1 (2022-07-13) (64-bit), Win10.