1774815 - Make sure if layers connection is requested by parent

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

Current implementation is not clear about meaning of "mLayersConnected == Some(false)".

It has the following 2 meanings.

• [1] parent side does not request to connect layers.
• [2] parent side requested to connect layers, but the connect was failed.

We need to distinguish between [1] and [2]. In [1] case, we do not need to try to connect layers in ReinitRendering.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1774815 - Make sure if layers connection is requested by parent

Comment 2

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9281824 [details]
Bug 1774815 - Make sure if layers connection is requested by parent

:jnicol, does the patch work for you?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e272ca28c11b
Make sure if layers connection is requested by parent r=jnicol,gfx-reviewers,bradwerth

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/e272ca28c11b

Comment 5

[Jamie Nicol [:jnicol]]

Yes, this still fixes the bug for me. Thanks Sotaro

Comment 6

[Jamie Nicol [:jnicol]]

Comment on attachment 9281824 [details]
Bug 1774815 - Make sure if layers connection is requested by parent

Beta/Release Uplift Approval Request

• User impact if declined: If we uplift bug 1774201 without this then we will regress bug 1728062
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1728062
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very small change. Makes us only skip reinitializing the compositor if we never attempted to initialize it in the first place.
• String changes made/needed:
• Is Android affected?: Yes

Comment 7

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9281824 [details]
Bug 1774815 - Make sure if layers connection is requested by parent

We are out of the beta cycle and releng is currently merging mozilla-beta to mozilla-release before we build our RC. Morphing this into a release build uplift request.

Comment 8

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9281824 [details]
Bug 1774815 - Make sure if layers connection is requested by parent

Taking with bug 1774201 on the 102 release and 102esr.

Comment 9

[Pascal Chevrel (relman team) -> :pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/920fc6c4594a

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr102/rev/f7216c314171