1775040 - When opening a new video while in PiP subtitles appear to be enabled even when these are not available

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Peter Magyari (Desktop QA)]

Found in

• Firefox Nightly 103.0a1

Affected versions

• Nightly v103.0a1

Affected platforms

• All

Steps to reproduce

1. Launch browser.
2. Play a video example
3. Make sure to enable subtitles (CC).
4. Play the video in Picture-in-Picture mode.
5. Without closing PiP navigate to another video from the right side of the page.
6. The new video starts playing in Picture-in-Picture mode.
7. Click on the subtitle-settings button inside the PiP window.
8. The subtitle(s) appear to be enabled.

Expected result

• When subtitles aren't enabled in the main window or aren't available at all it should not appear as enabled inside PiP window.

Actual result

• The subtitle(s) appear as if they are enabled when they are not or no subs are available whatsoever.

Regression range

• It is not a regression.

Additional notes

• This only happens when the second video has no or only has auto-generated subtitles (which are not automatically enabled when the video is loaded)

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1775040 - Hide subtitles button when video is emptied. r=#pip-reviewers!

Comment 2

[Ania]

Let's please request the uplift for this, so the QA team can verify it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f80ee50246e6
Hide subtitles button when video is emptied. r=pip-reviewers,mhowell

Comment 4

[Niklas Baumgardner [:niklas]]

Comment on attachment 9283060 [details]
Bug 1775040 - Hide subtitles button when video is emptied. r=#pip-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: We want to include this change for the release of 103. The user can change the font size while no subtitles exist and the user should only be able to change the font size if subtitles exist.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: STR:

1. Navigate to https://www.youtube.com/watch?v=XdKzUbAiswE
2. Make sure the subtitles on are and open a PiP window
3. Confirm that the subtitles settings button exists in the PiP window.
4. Now click one of the videos on the right side of the webpage

Result:
The new YT video should not have subtitles and the subtitles settings button will no longer be in the PiP window

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky because this only occurs when the user is switching videos with subtitles enabled
• String changes made/needed: No
• Is Android affected?: No

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f80ee50246e6

Comment 6

[Peter Magyari (Desktop QA)]

Verified fixed using Firefox Nightly 104.0a1 (20220706214039) on MacOS 11 and Windows 10.

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9283060 [details]
Bug 1775040 - Hide subtitles button when video is emptied. r=#pip-reviewers!

Approved for 103.0b6, thanks.

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/65ed5ed6ea52

Comment 9

[Peter Magyari (Desktop QA)]

Verified fixed using Firefox Beta 103.0b6 (20220707185904) on MacOS 11, Ubuntu 20.04 and Windows 10.