177506 - turning off "hide tab bar ..." has no effect until new tab/window is opened.

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P4)

Description

[Josh]

Observed in Phoenix 0.4 on both Windows XP and Linux.

Turning off the "hide tab bar when only one tab is open" option in the
preferences does not have an effect until an additional tab is opened.

To recreate:

1.  Load Phoenix with the "hide tab bar ..." option enabled.
2.  Ensure that only ONE TAB is open.
3.  Go into preferences, turn off "hide tab bar ..." option.
4.  Close preferences.
5.  Observe that a tab for the current page did NOT appear.
6.  Go to "File -> New Tab"
7.  Observe that you now have a tab for the original page, and a new tab.
8.  Close the new tab, observe that you now have the tab for the original page.

Comment 1

[David Tenser [:djst]]

Confirming.

Comment 2

[David Tenser [:djst]]

*** Bug 178284 has been marked as a duplicate of this bug. ***

Comment 3

[Blake Ross]

-> hyatt

Comment 4

[Prognathous]

> 3.  Go into preferences, turn off "hide tab bar ..." option.

Where? I can't seem to find this option in Firebird 0.6 (neither in Options nor
in about:config).

Prog.

Comment 5

[Simon Paquet [:sipaq]]

Marking WONTFIX, since this option has been removed from the options menu.

Comment 6

[noririty]

Just for note:
I can still confirm this bug.

1. Open about:config
2. browser.tabs.autoHide true -> false / false -> true

The change reflected immediately with Mozilla.
But it does not have an effect until an additional tab is opened in case of
Mozilla Firebird .

Comment 7

[Simon Paquet [:sipaq]]

Ok Nori, I'm reopening this.

Comment 8

[Mike Connor [:mconnor]]

per discussion with noririty, returning to WONTFIX status, I don't know of any
other prefs within about:config that will update UI automatically on change. 
Most are affected by the next action that references them, just as this pref does.

On the other hand, if this option goes back into the GUI via bug 191746, it
should work.  To that end I added a comment stating as much, and I will update
the patch there if this is to go in.

Comment 9

[Mike Connor [:mconnor]]

taking QA contact, sorry about the bugspam

Comment 10

[Brant Gurganus]

VERIFYING obvious WONTFIX bugs.  Filter on firebirdWontFix to filter these bugs.
 I skipped a few that I'm unsure about from their summary and will manually go
through them.

Comment 11

[Jesse Ruderman]

This pref has UI now, so reopening.

Comment 12

[Rhonda Reese]

still has no effect after new tab is opened:
i opened the new tab differently - right-click a link, select 'open in new tab'.
 now i have 2 tabs open, but still no tab bar.

Comment 13

[Steffen Wilberg]

-> Tabbed Browser.

Comment 14

[Steffen Wilberg]

*** Bug 248241 has been marked as a duplicate of this bug. ***

Comment 15

[Ali Ebrahim]

I wonder if this is related at all to bug 248196.

Comment 16

[Steffen Wilberg]

*** Bug 251789 has been marked as a duplicate of this bug. ***

Comment 17

[Tracy Walker [:tracy]]

*** Bug 248196 has been marked as a duplicate of this bug. ***

Comment 18

[Tracy Walker [:tracy]]

This works in Mozilla 1.7.3. With only one page open, the tabbar immediately
becomes visible upon okay of the preference dialog after changing the pref for
Hide tabbar when only one tab is open. Conversely, changing the pref back hides
the tabbar as expected.  This is happening dynamically. Need to make Firefox do
the samething.

note: Currently on Firefox, after the pref is changed, any new windows opened do
show the tabbar with a single tab open.

Comment 19

[Asa Dotzler [:asa]]

p4 priority - not a blocker. if a patch materializes, please nominate for aviary
approval. 

Comment 20

[Prognathous]

Any new window that is opened (after this pref is disabled) displays the
tab-bar. Changing summary accordingly.

Prog.

Comment 21

[Asaf Romano (gone)]

Attachment: patch v1

Comment 22

[Nickolay_Ponomarev]

*** Bug 272470 has been marked as a duplicate of this bug. ***

Comment 23

[Prognathous]

Asaf, you might want to ask someone else to review your patch. I'm not sure
mconnor is free to do it.

Prog.

Comment 24

[Asaf Romano (gone)]

mconnor is (more or less) the only one who does reviews for browser/ (which are
not bookmarks-related).

Comment 25

[Asaf Romano (gone)]

Checking in base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.378; previous revision: 1.377
done