1775126 - "ReportSiteIssueHelper:GetLog: message reply cannot be cloned." from Report site issue

Status: RESOLVED FIXED

(Web Compatibility :: Tooling & Investigations, defect, P2)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

1. Open https://www.typescriptlang.org/play?#code/KYDwDg9gTgLgBDAnmYcCSATYA7GBLAMz2CjgF50tdDioBZYGAQzgDI4AFKPAWyakSYc+IiQDcAKAmhIsOHlwkCTAMaouvfoKojaEuHFAwcGAM5wASsBXQMAHgCiIFQBsArljumY3bAHMAGjgAcgB9UJseMCYYYIA+IKFqUSg4uABvAF8pBWMoZTVKYRoSBmYM-TgAegAqGsq4GrgAQTgCYBi3KFQ8cyxTFW4AI2AMOCHEOCZseR0S0htcJgUFPwQAC1QAA3DI6JgtuDAoCBRYRAA6BvqDRvQZiBhN0gB3W1MgvDmU8xe8J4gbngOwiECiMUO-BwwXg2GswFMpn4eBck3anW6H2u4yBcE2LjACAgcDh3g2qHRMC6CKOJzOqKutxuBiaAHVNjNprNiik8UxzCwQXsIeMXBAVABrT7wbrHBHCcz-cxDfl4FRwUxuMCyGABbEKDBqmKrDYxKZwHgrPgueRRFzAHjCY0QB4Ec0ENzYFT4F1MFz-Sa9eRe9xYDCMlnY9lm-5wWWYhWGECqGCouBYFDYMxwCBup6oYAANwg7h9rvJbQ6VO6OcLJAQvGAeqZ40e62DCBIPHMuY1KBUNBUzuwAqzObdQxOL1M9c12ugMAjjSqlV2YP2AH4AFwaxA8IYlyTZCT2+BfHdJXT1ijpOBr8EwHcAZT3B5cAAoAJRwTJiIA
2. Try opening Report site issue

Expected: A new tab should open
Actual: Nothing happens. Multiprocess Browser Toolbox says:

[Exception... "ReportSiteIssueHelper:GetLog: message reply cannot be cloned."  nsresult: "0x80004005 (DataCloneError)"  location: "<unknown>"  data: no] ExtensionCommon.jsm:724
    normalizeError resource://gre/modules/ExtensionCommon.jsm:724
    recvAPICall resource://gre/modules/ExtensionParent.jsm:1062
    (Async: promise callback)
    recvAPICall resource://gre/modules/ExtensionParent.jsm:1053
    AsyncFunctionNext self-hosted:715
    (Async: async)
    recvAPICall self-hosted:1198
    _recv resource://gre/modules/ConduitsChild.jsm:82
    receiveMessage resource://gre/modules/ConduitsParent.jsm:450
WebCompat Reporter: unexpected error Error: An unexpected error occurred background.js:26:15
    <anonymous> moz-extension://a5abb3d7-0bfe-42fb-ad72-cfd7d7f66624/background.js:26
    (Async: promise callback)
    <anonymous> moz-extension://a5abb3d7-0bfe-42fb-ad72-cfd7d7f66624/background.js:21

This does not happen when I try the same on Bugzilla.

Comment 1

[Dennis Schubert [:denschub]]

Seems like it's only specific sites, and not general reporter breakage, which is good.

Tom, do you have time to look into that soon'ish? If not, let me know and I'll dig into that. :)

Comment 2

[Thomas Wisniewski [:twisniewski]]

Ah, the problem turns out to be that they're logging JS Symbol objects to the console, which don't structured clone. This is easy enough to fix, we just need to add this to the cases in getPreview, here:

    case "symbol":
      return value.toString();

I'll post a patch for review soon.

Comment 3

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1775126 - fix a structured-cloning failure in the webcompat report-site-issue feature, and update and re-enable some of its tests; r?denschub

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0771d3e5261
fix a structured-cloning failure in the webcompat report-site-issue feature, and update and re-enable its tests; r=denschub,webcompat-reviewers

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing for causing mochitest failures on browser_report_site_issue.js

Backout link
Push with failures
Link to failure log
Failure line :
TEST-UNEXPECTED-FAIL | browser/extensions/report-site-issue/test/browser/browser_report_site_issue.js | Test timed out

Comment 6

[Thomas Wisniewski [:twisniewski]]

Well, that's nonsensical. I wonder if it's related to Fission, since I see something similar here: https://bugzilla.mozilla.org/show_bug.cgi?id=1248632

I'd rather have some test coverage than none, so I'll try re-landing with the tests disabled in Fission later, to confirm if that's the likely culprit.

Comment 7

[Thomas Wisniewski [:twisniewski]]

No, I was wrong. It looks like the failed job in that try-run was running in e10s, not without it. so I'm... at a complete loss. For now I'll disable that test so we can at least fix the feature, and we can file a follow-up to determine what might be going on here.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07ec40d4c3cb
fix a structured-cloning failure in the webcompat report-site-issue feature, and update and re-enable some of its tests; r=denschub,webcompat-reviewers

Comment 9

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/07ec40d4c3cb