177527 - Clear selection of tasks/events if item that is selected is hidden

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Mike Potter]

If the selected to do item is being hidden, clear the selection so that the
delete button becomes inactive.

Comment 1

[Mike Potter]

New contact from [e-mail] to [e-mail]
Filter on string OttawaMBA to get rid of these messages. 
Sorry for the spam.

Comment 2

[Jussi Kukkonen]

But the delete button doesn't work on tasks, it's active only because an event
is selected.

However, the same happens with events: 
 - select an event
 - uncheck calendar in calendars tab
 - edit and delete buttons are active

The selection stuff should probably be another bug? "It should be clear what
(days/tasks/events) are currently selected" or something.

Changing summary ( to-do --> task and event). 

Comment 3

[Joey Minta]

Attachment: patch

This makes calCompositeCalendarObserver examine the array of selected events
whenever a calendar is unchecked.  It doesn't do anything when a calendar is
re-checked, which means that if you select an event, uncheck and re-check the
calendar, it will no longer be selected.  This feels like the right behavior,
intuitively, and keeps us from having to store extra information when calendars
are unchecked.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 190829 [details] [diff] [review]
patch

>+            if (oldSelectedEvents[i].calendar != aCalendar)

i've been told that that check might give false results sometimes. The xpcom
calendar object might get rewrapped, and then the comparison (of the wrappers)
will fail. It would be better to compare calendar.uri.spec.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

or even better: calendar.uri.equals(othercalendar.uri)

Comment 6

[Joey Minta]

Attachment: patch v2

Now using uri.equals

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 190911 [details] [diff] [review]
patch v2

r=mvl (although i think gCalendarWindow has to go away one day)

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in

Comment 9

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!