Land follow-up patches for frame pointer changes
Categories
(Core :: JavaScript Engine: JIT, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox103 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
Details
Attachments
(4 files)
I have a few patches fixing minor issues I noticed the past weeks.
|
Assignee | |
Comment 1•2 years ago
|
||
- Some methods can forward to the implementation in
JitFrameLayout. - Replace
offsetOfFoomethods with the ones fromJitFrameLayoutnow thatFramePointerOffsetis gone.
The next patch will tidy up JitFrameLayout::argv.
|
|
Assignee | |
Comment 2•2 years ago
|
||
The argv method on BaselineFrame does not include this, but the one on JitFrameLayout does.
We can be a bit more explicit about this.
Depends on D149962
|
|
Assignee | |
Comment 3•2 years ago
|
||
The exception trampoline now uses a Label + jump to jump to the bailout tail
code, after setting the stack pointer to the JitFrameLayout of the bailing frame.
In the bailout tail code, we can now assert the stack pointer is what we expect
instead of clobbering it ourselves.
Depends on D149963
|
|
Assignee | |
Comment 4•2 years ago
|
||
This shouldn't be perf-sensitive, but on 64-bit platforms it's more natural to copy
eight bytes at a time.
Depends on D149964
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fe1573567554 part 1 - Tidy up BaselineFrame methods. r=iain https://hg.mozilla.org/integration/autoland/rev/1c63e0fe6f72 part 2 - Split JitFrameLayout::argv in actualArgs and thisAndActualArgs. r=iain https://hg.mozilla.org/integration/autoland/rev/bc3175f5f05e part 3 - Set stack pointer in exception trampoline for exception bailouts. r=iain https://hg.mozilla.org/integration/autoland/rev/77501b8565ea part 4 - Use loadPtr/storePtr instead of load32/store32 in bailout code. r=iain
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fe1573567554
https://hg.mozilla.org/mozilla-central/rev/1c63e0fe6f72
https://hg.mozilla.org/mozilla-central/rev/bc3175f5f05e
https://hg.mozilla.org/mozilla-central/rev/77501b8565ea
Description
•