1775442 - The whole subtitle-settings-panel is selected after changing font size and exiting PiP fullscreen

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Peter Magyari (Desktop QA)]

Attachment: Screenshot 2022-06-22 at 13.17.44.png

Found in

• Firefox Nightly 103.0a1

Affected versions

• Nightly v103.0a1

Affected platforms

• All

Steps to reproduce

1. Launch browser.
2. Play a video that has subtitles (example).
3. Toggle Picture-in-Picture mode.
4. Double click the PiP window to make it run in fullscreen.
5. Open the subtitle-settings-panel and change the font size.
6. Click the subtitle-settings-button to close the panel and then double-click the video to exit fullscreen.
7. Click the subtitle-settings-button once again to open the panel.

Expected result

• The whole sub-settings panel is "selected".

Regression range

• It is not a regression.

Actual result

• The panel opens without being "selected".

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1775442 - Remove selection from subtitles settings panel when fullscreen change. r=#pip-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33c8f646638c
Remove selection from subtitles settings panel when fullscreen change. r=pip-reviewers,mhowell

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/33c8f646638c

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:niklas, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox103 to wontfix.

For more information, please visit auto_nag documentation.

Comment 5

[Peter Magyari (Desktop QA)]

Verified the fix on Windows 7/10, MacOS 11 and Ubuntu 22.04 using Nightly 104.0a1 (20220704214252)

Comment 6

[Niklas Baumgardner [:niklas]]

Comment on attachment 9283665 [details]
Bug 1775442 - Remove selection from subtitles settings panel when fullscreen change. r=#pip-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: The subtitles settings panel text can get selected when changing fullscreen state. We don't want this text to be selected and we don't want users to see this in the release of 103.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk. This is a visual change of removing the selected text when changing fullscreen state
• String changes made/needed: Mo
• Is Android affected?: No

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9283665 [details]
Bug 1775442 - Remove selection from subtitles settings panel when fullscreen change. r=#pip-reviewers!

Approved for 103.0b5, thanks.

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/10b3288cb0d7

Comment 9

[Peter Magyari (Desktop QA)]

Verified fixed on Windows 7/10, MacOS 11 and Ubuntu 22.04 using Firefox 103.0b5 (20220705185846)