1775519 - Extraneous line breaks in PiP on auto-generated subs in youtube videos are observed again if the user chooses the large subtitle font size

Status: NEW

(Toolkit :: Picture-in-Picture, defect, P2)

Description

[Daniel Bodea [:danibodea]]

Note

• When the user plays a youtube video with auto-generated subtitles in a smaller PiP, while the sub font size is large, he will notice extraneous line breaks again.

** Found in**

• Nightly v103.0a1

Affected versions

• Nightly v103.0a1

Affected platforms

• all

Steps to reproduce

1. Load this video and pause it at 7:32.
2. Set the subtitle size to large.
3. Shrink the PiP, slowly.

Expected result

• Extraneous line breaks are not observed:
  "
  the room we would immediately know
  who he was all of a sudden...
  "

Actual result

• Extraneous line breaks are observed again:
  "
  the room we would immediately know
  who
  he was all of a sudden...
  "

Regression range

• Not really a regression but an issue that started appearing (again) after the implementation of the subtitle size options.

Additional notes

• additional_note1

Comment 1

[Molly Howell (she/her) (mostly inactive)]

Do you have a link to the video you're talking about?

Comment 2

[Daniel Bodea [:danibodea]]

Yes, I'm sorry. I've updated the description with the link.

Comment 3

[Daniel Bodea [:danibodea]]

Attachment: extraneous line break in pip on auto-generated subs of YT.png

Knowing that this bug was prioritized as "can't reproduce" in the Nightly 103 QA Bug Priority List, I am re-writing more detailed steps to reproduce:

1. Load https://youtu.be/kaUemcqIQ-k?t=452
   (on a generic 1920x1080 resolution monitor)
2. Play it and pause it immediately (at 7:32).
3. Activate subtitles / closed captions.
4. Click the "cog" icon to open settings, then subtitles and choose "English (auto-generated)"
5. Launch the video in PiP.
6. Change the subtitle font size to large (in the PiP).

Actual: Extraneous line break in PiP on auto-generated subs in youtube videos is observed.
"
the room we would immediately know
who
he was
"

Expected:
"
the room we would immediately know
who he was
"

Comment 4

[Daniel Bodea [:danibodea]]

I think it best if I lower the severity to S4 since it's just a minor cosmetic issue and occurs only in auto-generated subs.

Comment 5

[Ania]

If we can distinguish auto-generated subs from regular ones in the stream, let's completely removed the line breaks and let the subs reach the max-width of their container.
If we can't distinguish between them, we'll probably have to put a won't fix on this - because regular subs proper line breaks matter and it's important to preserve them.