Closed Bug 1775819 Opened 3 years ago Closed 1 year ago

Frequent browser/components/urlbar/tests/browser/browser_switchTab_inputHistory.js | single tracking bug

Categories

(Firefox :: Address Bar, defect, P3)

Product:
Firefox
Component:
Address Bar
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
135 Branch
Tracking Flags:
Tracking Status
firefox135 --- fixed

People

(Reporter: jmaher, Assigned: mak)

References

Details

(Keywords: intermittent-failure, intermittent-testcase, Whiteboard: [sng][stockwell disable-recommended])

Attachments

(1 file)

Bug 1775819 - Wait for tab to be registered in browser_switchTab_inputHistory.js. r=jteow
48 bytes, text/x-phabricator-request
Details | Review
No description provided.

Additional information about this bug failures and frequency patterns can be found by running: ./mach test-info failure-report --bug 1775819

Severity: -- → S4

Fixing this in bug 1883845.

Depends on: 1883845

it looks like it's still happening even after my fix

TEST-PASS | browser/components/urlbar/tests/browser/browser_switchTab_inputHistory.js | Url is the first non-heuristic result - "https://example.com/" == "https://example.com/" -
[task 2024-03-09T12:52:51.514Z] 12:52:51 INFO - Buffered messages finished
[task 2024-03-09T12:52:51.523Z] 12:52:51 INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_switchTab_inputHistory.js | Should be a switch tab result - 1 == 3 - {"filename":"chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_switchTab_inputHistory.js","name":"queryAndCheckOneSwitchTabResult","sourceId":659,"lineNumber":124,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_switchTab_inputHistory.js","name":"test_adaptive_nonadaptive_container_dedupe_switch_tab","sourceId":659,"lineNumber":136,"columnNumber":11,"sourceLine":"","asyncCause":null
[task 2024-03-09T12:52:51.523Z] 12:52:51 INFO - Stack trace:
[task 2024-03-09T12:52:51.523Z] 12:52:51 INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_switchTab_inputHistory.js:queryAndCheckOneSwitchTabResult:124
[task 2024-03-09T12:52:51.523Z] 12:52:51 INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_switchTab_inputHistory.js:test_adaptive_nonadaptive_container_dedupe_switch_tab:136

Hi, Olivia! This bug started to be frequent after your push, as you can see here. Please have a look.

Flags: needinfo?(ohall)
Summary: Intermittent browser/components/urlbar/tests/browser/browser_switchTab_inputHistory.js | single tracking bug → Frequent browser/components/urlbar/tests/browser/browser_switchTab_inputHistory.js | single tracking bug

Thanks for the heads-up! The patches on bug 1931062 updated the behavior on how process/browser priority worked in fission.

I'm not familiar with browser chrome mochitests, but I took a look at test_adaptive_nonadaptive_container_dedupe_switch_tab. I suppose it is possible that a tab that had Foreground priority now has Background priority and the change exacerbated a race condition in the original test?

I also triggered this test a few times on a before branch and after branch on the patch to be conclusive since the relationship to behavior change and failure isn't clear to me:

Edit: Appears conclusive that bug 1931062 increased the volume of failures after comparing these two trys.

Nika, do you have any leads or what do you think?

Flags: needinfo?(ohall) → needinfo?(nika)

Based on a quick scan of the failure, it appears that the test is trying to check that the tab which was previously loaded is shown as a "switch to tab" suggestion in the URL bar. I assume this means that the tab is not active, which could mean that it is backgrounded. Perhaps the wait which is happening in https://searchfox.org/mozilla-central/rev/5ad94327fc03d0e5bc6aa81c0d7d113c2dccf947/browser/components/urlbar/tests/browser/browser_switchTab_inputHistory.js#110 isn't waiting long enough for some notification from the content process to arrive, indicating that the tab has finished loading and would be visible to the URLBar code? I unfortunately don't know well enough how this information is populated to say for certain.

Flags: needinfo?(nika)

Let me have a look at this, as it looks like now it's easier to reproduce.

Assignee: nobody → mak
Status: NEW → ASSIGNED
Whiteboard: [sng]
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/4ec555cacfed Wait for tab to be registered in browser_switchTab_inputHistory.js. r=urlbar-reviewers,dao

https://hg.mozilla.org/mozilla-central/rev/4ec555cacfed

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox135: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: