Closed Bug 1776076 Opened 2 years ago Closed 2 years ago

Memory reports not visible in crash-stats for many crashes which claim to have them

Categories

(Toolkit :: Crash Reporting, defect)

Product:
Toolkit
Component:
Crash Reporting
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: rkraesig, Unassigned)

References

Details

Handling of the memory report file is very brittle and not well tested. I can think of several reasons why this might be happening, including the fact that we set the annotation then removed the file, or failed to submit it. There's definitely room to improve its handling on the client side but I guess we could also patch up socorro to strip the annotation if the report isn't really there when processing a crash.

I can add a processor rule that removes the annotation and adds a processor note. Then we can search for all the crash reports that had an annotation, but didn't have a memory report. Does that seem worth doing?

Flags: needinfo?(gsvelto)

I could get rid of the annotation entirely and let Socorro populate it only if the memory report is actually there, WDYT? Or maybe we don't need the annotation at all if it's possible for Socorro to search for all reports that do have a memory report attached to them. In this case it'd be redundant and I'd get rid of it entirely.

Flags: needinfo?(gsvelto)

With the crash_report_keys field, it's straight-forward to find all crash reports that have a memory report. The report view "raw data and minidumps" tab (albeit not well-named) will show the memory report if it's there. I think that covers all the use cases and we don't additionally need the annotation.

Indeed, I'll get rid of the annotation then.

The severity field is not set for this bug.
:gsvelto, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(gsvelto)

This was fixed by bug 1776279.

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(gsvelto)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.