1776109 - Try hiding caches/indexedDB/serviceWorker in PBMode

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

... hoping that doing so will better meet the expectation of feature detection in existing websites and thus prevent breakage.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1776109 - Part 3: Hide caches/indexedDB/serviceWorker in PBMode r=asuth

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

(Just want to link related bugs)

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1776109 - Part 1: Fall back to nsIPrincipal in StorageAllowedForWindow r=asuth

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1776109 - Part 2: Add ServiceWorkersEnabled() for service worker interfaces exposure r=asuth

Depends on D150282

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66bb4c49d615
Part 1: Fall back to nsIPrincipal in StorageAllowedForWindow r=asuth,anti-tracking-reviewers,pbz
https://hg.mozilla.org/integration/autoland/rev/1cdbbad1d996
Part 2: Add ServiceWorkersEnabled() for service worker interfaces exposure r=asuth
https://hg.mozilla.org/integration/autoland/rev/8e76401f7c43
Part 3: Hide caches/indexedDB/serviceWorker in PBMode r=asuth,twisniewski

Comment 6

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing multiple failures. CLOSED TREE

Backout link
Push with failures
Link to bc20 failure log
Link to bc1 failure log
Link to bustage failure log

Failure line :
TEST-UNEXPECTED-FAIL | dom/cache/test/browser/browser_cache_pb_window.js | Test timed out
TEST-UNEXPECTED-FAIL | dom/indexedDB/test/browser_permissionsPromptDeny.js | Test timed out -
TEST-UNEXPECTED-FAIL | hazards | unrooted 'aGlobal' of type 'JSObject*' live across GC call at dom/serviceworkers/ServiceWorker.cpp:54

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/021a94a72d0c
Part 1: Fall back to nsIPrincipal in StorageAllowedForWindow r=asuth,anti-tracking-reviewers,pbz
https://hg.mozilla.org/integration/autoland/rev/80fb3c3a5a40
Part 2: Add ServiceWorkersEnabled() for service worker interfaces exposure r=asuth
https://hg.mozilla.org/integration/autoland/rev/b6222b68a403
Part 3: Hide caches/indexedDB/serviceWorker in PBMode r=asuth,twisniewski

Comment 8

[Iulian Moraru]

Backed out for causing hazzard build bustages on ServiceWorker.cpp.

Push with failures

Failure log

Backout link

[task 2022-06-30T04:46:07.596Z] ++ perl -lne 'print $1 if m!found (\d+)/\d+ allowed errors!' /builds/worker/workspace/haz-browser/heapWriteHazards.txt
[task 2022-06-30T04:46:07.598Z] + NUM_WRITE_HAZARDS=0
[task 2022-06-30T04:46:07.598Z] ++ grep -c '^Function.*expected hazard.*but none were found' /builds/worker/workspace/haz-browser/rootingHazards.txt
[task 2022-06-30T04:46:07.599Z] + NUM_MISSING=0
[task 2022-06-30T04:46:07.599Z] + set +x
[task 2022-06-30T04:46:07.599Z] TinderboxPrint: rooting hazards<br/>1
[task 2022-06-30T04:46:07.599Z] TinderboxPrint: (unsafe references to unrooted GC pointers)<br/>247
[task 2022-06-30T04:46:07.599Z] TinderboxPrint: (unnecessary roots)<br/>1220
[task 2022-06-30T04:46:07.599Z] TinderboxPrint: missing expected hazards<br/>0
[task 2022-06-30T04:46:07.599Z] TinderboxPrint: heap write hazards<br/>0
[task 2022-06-30T04:46:07.600Z] TEST-UNEXPECTED-FAIL | hazards | unrooted 'aGlobal' of type 'JSObject*' live across GC call at dom/serviceworkers/ServiceWorker.cpp:57
[task 2022-06-30T04:46:07.601Z] TEST-UNEXPECTED-FAIL | hazards | 1 rooting hazards detected
[task 2022-06-30T04:46:07.601Z] TinderboxPrint: documentation<br/><a href='https://wiki.mozilla.org/Javascript:Hazard_Builds#Diagnosing_a_rooting_hazards_failure'>static rooting hazard analysis failures</a>, visit "Inspect Task" link for hazard details
[task 2022-06-30T04:46:07.601Z] + grab_artifacts
[task 2022-06-30T04:46:07.601Z] + local artifacts
[task 2022-06-30T04:46:07.601Z] + artifacts=/builds/worker/artifacts
[task 2022-06-30T04:46:07.601Z] + '[' -d /builds/worker/workspace/haz-browser ']'
[task 2022-06-30T04:46:07.601Z] + cd /builds/worker/workspace/haz-browser
[task 2022-06-30T04:46:07.601Z] + ls -lah
[task 2022-06-30T04:46:07.604Z] total 11G
[task 2022-06-30T04:46:07.604Z] drwxr-xr-x 3 worker worker 4.0K Jun 30 04:46 .

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c75ade7f3a3a
Part 1: Fall back to nsIPrincipal in StorageAllowedForWindow r=asuth,anti-tracking-reviewers,pbz
https://hg.mozilla.org/integration/autoland/rev/3bbb2f9bf6f6
Part 2: Add ServiceWorkersEnabled() for service worker interfaces exposure r=asuth
https://hg.mozilla.org/integration/autoland/rev/e64c83e9d62d
Part 3: Hide caches/indexedDB/serviceWorker in PBMode r=asuth,twisniewski

Comment 10

[Kagami Rosylight [:saschanaz] (they/them)]

Sorry for causing repeated backouts 😞

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c75ade7f3a3a
https://hg.mozilla.org/mozilla-central/rev/3bbb2f9bf6f6
https://hg.mozilla.org/mozilla-central/rev/e64c83e9d62d