Closed Bug 1776207 Opened 2 years ago Closed 2 years ago

Perma browser/base/content/test/performance/browser_startup_content.js | all known modules scripts should have been loaded - Got 1, expected +0 when Gecko 103 merges to Beta on 2022-06-27

Tracking

()

Status:

VERIFIED FIXED

Milestone:

104 Branch

Tracking Flags:

Tracking

Status

firefox-esr91

---

unaffected

firefox-esr102

---

unaffected

firefox101

---

unaffected

firefox102

---

unaffected

firefox103

fixed

firefox104

---

verified

People

(Reporter: CrissCozmuta, Assigned: kmag)

References

(Regression)

Details

(Keywords: perf-alert, regression)

Attachments

(3 files)

Bug 1776207: Part 1 - Remove obsolete _xpcom_factory definitions. r=mccr8 2 years ago Kris Maglione [:kmag] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1776207: Part 2 - Don't load StartupRecorder in content processes. r=florian 2 years ago Kris Maglione [:kmag] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1776207: Part 3 - Remove generateNSGetFactory now that it isn't used anymore. r=mccr8 2 years ago Kris Maglione [:kmag] 48 bytes, text/x-phabricator-request		Details \| Review

Cristina Cozmuta (:CrissCozmuta)

Reporter

Description

•

2 years ago

Central-as-beta simulation
How to run these simulations

Failure log 1
Failure line 1 : TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_content.js | all known modules scripts should have been loaded - Got 1, expected +0
Failure log 2
Failure line 2 : TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup.js | should have no unexpected modules loaded before profile selection - Got 1, expected +0

[task 2022-06-23T12:09:59.511Z] 12:09:59     INFO - TEST-START | browser/base/content/test/performance/browser_startup_content.js
[task 2022-06-23T12:10:00.088Z] 12:10:00     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "http://example.com/browser/browser/base/content/test/performance/file_empty.html" line: 0}]
[task 2022-06-23T12:10:00.174Z] 12:10:00     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_content.js | should have no unexpected modules loaded on content process startup - 
[task 2022-06-23T12:10:00.184Z] 12:10:00     INFO - TEST-INFO | started process screentopng
[task 2022-06-23T12:10:01.301Z] 12:10:01     INFO - TEST-INFO | screentopng: exit 0
[task 2022-06-23T12:10:01.303Z] 12:10:01     INFO - Buffered messages logged at 12:09:59
[task 2022-06-23T12:10:01.304Z] 12:10:01     INFO - Entering test bound 
[task 2022-06-23T12:10:01.305Z] 12:10:01     INFO - Buffered messages finished
[task 2022-06-23T12:10:01.307Z] 12:10:01     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_content.js | all known modules scripts should have been loaded - Got 1, expected +0
[task 2022-06-23T12:10:01.307Z] 12:10:01     INFO - Stack trace:
[task 2022-06-23T12:10:01.308Z] 12:10:01     INFO - chrome://mochikit/content/browser-test.js:test_is:1429
[task 2022-06-23T12:10:01.308Z] 12:10:01     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:checkLoadedScripts:883
[task 2022-06-23T12:10:01.309Z] 12:10:01     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup_content.js:null:174
[task 2022-06-23T12:10:01.312Z] 12:10:01     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-06-23T12:10:01.312Z] 12:10:01     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_content.js | modules is expected to load for content process startup but wasn't: resource:///modules/StartupRecorder.jsm - 
[task 2022-06-23T12:10:01.313Z] 12:10:01     INFO - Stack trace:
[task 2022-06-23T12:10:01.313Z] 12:10:01     INFO - chrome://mochikit/content/browser-test.js:test_ok:1401
[task 2022-06-23T12:10:01.314Z] 12:10:01     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:checkLoadedScripts:890
[task 2022-06-23T12:10:01.314Z] 12:10:01     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup_content.js:null:174
[task 2022-06-23T12:10:01.317Z] 12:10:01     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_content.js | should have no unexpected frameScripts loaded on content process startup - 
[task 2022-06-23T12:10:01.318Z] 12:10:01     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_content.js | all known frameScripts scripts should have been loaded - 
[task 2022-06-23T12:10:01.318Z] 12:10:01     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_content.js | should have no unexpected processScripts loaded on content process startup - 
[task 2022-06-23T12:10:01.319Z] 12:10:01     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_content.js | all known processScripts scripts should have been loaded - 
[task 2022-06-23T12:10:01.321Z] 12:10:01     INFO - Leaving test bound 
[task 2022-06-23T12:10:01.321Z] 12:10:01     INFO - GECKO(1639) | MEMORY STAT | vsize 20983375MB | residentFast 1230MB
[task 2022-06-23T12:10:01.322Z] 12:10:01     INFO - TEST-OK | browser/base/content/test/performance/browser_startup_content.js | took 1026ms

[task 2022-06-23T12:30:32.521Z] 12:30:32     INFO - services loaded before becoming idle: @mozilla.org/url-classifier/jslib;1
[task 2022-06-23T12:30:32.521Z] 12:30:32     INFO - services loaded before becoming idle: @mozilla.org/login-manager/crypto/SDR;1
[task 2022-06-23T12:30:32.522Z] 12:30:32     INFO - services loaded before becoming idle: @mozilla.org/query-stripping-list-service;1
[task 2022-06-23T12:30:32.522Z] 12:30:32     INFO - services loaded before becoming idle: @mozilla.org/browser/nav-bookmarks-service;1
[task 2022-06-23T12:30:32.523Z] 12:30:32     INFO - services loaded before becoming idle: @mozilla.org/netwerk/cache-storage-service;1
[task 2022-06-23T12:30:32.523Z] 12:30:32     INFO - services loaded before becoming idle: @mozilla.org/dhcp-client;1
[task 2022-06-23T12:30:32.523Z] 12:30:32     INFO - services loaded before becoming idle: @mozilla.org/xpcom/memory-watcher;1
[task 2022-06-23T12:30:32.528Z] 12:30:32     INFO - TEST-INFO | started process screenshot
[task 2022-06-23T12:30:32.643Z] 12:30:32     INFO - TEST-INFO | screenshot: exit 0
[task 2022-06-23T12:30:32.650Z] 12:30:32     INFO - Buffered messages logged at 12:30:32
[task 2022-06-23T12:30:32.650Z] 12:30:32     INFO - Entering test bound 
[task 2022-06-23T12:30:32.651Z] 12:30:32     INFO - Buffered messages finished
[task 2022-06-23T12:30:32.651Z] 12:30:32     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup.js | should have no unexpected modules loaded before profile selection - Got 1, expected +0
[task 2022-06-23T12:30:32.651Z] 12:30:32     INFO - Stack trace:
[task 2022-06-23T12:30:32.652Z] 12:30:32     INFO - chrome://mochikit/content/browser-test.js:test_is:1429
[task 2022-06-23T12:30:32.652Z] 12:30:32     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup.js:null:190
[task 2022-06-23T12:30:32.652Z] 12:30:32     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-06-23T12:30:32.653Z] 12:30:32     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup.js | unexpected modules: resource://gre/modules/ComponentUtils.jsm - 
[task 2022-06-23T12:30:32.653Z] 12:30:32     INFO - Stack trace:
[task 2022-06-23T12:30:32.653Z] 12:30:32     INFO - 0 <TOP LEVEL> ["resource://gre/modules/XULStore.jsm":16:39]
[task 2022-06-23T12:30:32.653Z] 12:30:32     INFO - 1 _earlyBlankFirstPaint() ["resource:///modules/BrowserGlue.jsm":1474:16]
[task 2022-06-23T12:30:32.653Z] 12:30:32     INFO - 2 BG_observe() ["resource:///modules/BrowserGlue.jsm":1107:13]
[task 2022-06-23T12:30:32.654Z] 12:30:32     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup.js | all modules allowlist entries should have been used - 
[task 2022-06-23T12:30:32.654Z] 12:30:32     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup.js | chrome://webcompat/content/data/ua_overrides.jsm is not allowed before first paint - 
[task 2022-06-23T12:30:32.655Z] 12:30:32     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup.js | chrome://webcompat/content/lib/ua_overrider.jsm is not allowed before first paint - 
[task 2022-06-23T12:30:32.655Z] 12:30:32     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup.js | resource:///modules/AboutNewTab.jsm is not allowed before first paint - 
[task 2022-06-23T12:30:32.656Z] 12:30:32     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup.js | resource:///modules/BrowserUsageTelemetry.jsm is not allowed before first paint - 
[task 2022-06-23T12:30:32.656Z] 12:30:32     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup.js | resource:///modules/ContentCrashHandlers.jsm is not allowed before first paint - 
[task 2022-06-23T12:30:32.657Z] 12:30:32     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup.js | resource:///modules/ShellService.jsm is not allowed before first paint - 
[task 2022-06-23T12:30:32.657Z] 12:30:32     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup.js | resource://gre/modules/NewTabUtils.jsm is not allowed before first paint -

Flags: needinfo?(kmaglione+bmo)

Cristina Cozmuta (:CrissCozmuta)

Reporter

Comment 1

•

2 years ago

Hi Kris,

These seem to be related to the changes in https://bugzilla.mozilla.org/show_bug.cgi?id=1770237.
Can you please take a look ?
Thank you !

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Updated

•

2 years ago

tracking-firefox103: ? → +

Andrew McCreight [:mccr8]

Comment 2

•

2 years ago

Presumably this is related to bug 1771882. In other words, XULStore.jsm is used on non-Nightly branches.

Updated

•

2 years ago

Keywords: regression

Kris Maglione [:kmag]

Assignee

Comment 3

•

2 years ago

Attached file Bug 1776207: Part 1 - Remove obsolete _xpcom_factory definitions. r=mccr8 — Details

They only work with generateNSGetFactory definitions, which don't exist
anymore.

Phabricator Automation

Updated

•

2 years ago

Assignee: nobody → kmaglione+bmo

Status: NEW → ASSIGNED

Kris Maglione [:kmag]

Assignee

Comment 4

•

2 years ago

Attached file Bug 1776207: Part 2 - Don't load StartupRecorder in content processes. r=florian — Details

It isn't actually used in content processes, and causes failures in
non-Nightly/debug builds, where it isn't loaded.

Kris Maglione [:kmag]

Assignee

Comment 5

•

2 years ago

Attached file Bug 1776207: Part 3 - Remove generateNSGetFactory now that it isn't used anymore. r=mccr8 — Details

Kris Maglione [:kmag]

Assignee

Comment 6

•

2 years ago

(In reply to Andrew McCreight [:mccr8] from comment #2)

Presumably this is related to bug 1771882. In other words, XULStore.jsm is used on non-Nightly branches.

Yes. The old implementation was still defining an obsolete _xpcom_factory property on its implementation class, and importing ComponentUtils.jsm to do it.

Flags: needinfo?(kmaglione+bmo)

Norisz Fay [:noriszfay]

Comment 8

•

2 years ago

•

Edited

Hello, according to today's beta-sim it seems the patches are causing multiple other failures. Here's the link to the beta-sim .

Flags: needinfo?(kmaglione+bmo)

Comment hidden (Intermittent Failures Robot)

Pulsebot

Comment 10

•

2 years ago

Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c7edf0e1902f
Part 1 - Remove obsolete _xpcom_factory definitions. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/2841a1ebc685
Part 2 - Don't load StartupRecorder in content processes. r=florian

Pulsebot

Comment 11

•

2 years ago

Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f0631bbdcb44
Part 3 - Remove generateNSGetFactory now that it isn't used anymore. r=mccr8

bszekely

Comment 12

•

2 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/c7edf0e1902f
https://hg.mozilla.org/mozilla-central/rev/2841a1ebc685
https://hg.mozilla.org/mozilla-central/rev/f0631bbdcb44

Status: ASSIGNED → RESOLVED

Closed: 2 years ago

status-firefox104: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 104 Branch

u695164

Updated

•

2 years ago

Blocks: 1776840

Donal Meehan [:dmeehan]

Comment 13

•

2 years ago

Setting 103 to fixed as the regressor was backed out of 103 beta

status-firefox103: affected → fixed

Cristina Cozmuta (:CrissCozmuta)

Reporter

Comment 14

•

2 years ago

The patches were verified in today's beta sim

Status: RESOLVED → VERIFIED

status-firefox104: fixed → verified

Acasandrei Beatrice (needinfo me)

Comment 15

•

2 years ago

== Change summary for alert #34672 (as of Wed, 29 Jun 2022 12:42:03 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
1%	Base Content JS	macosx1015-64-shippable-qr	fission	1,648,210.67 -> 1,624,760.00
1%	Base Content JS	windows10-64-2004-shippable-qr	fission	1,619,436.00 -> 1,600,096.00
1%	Base Content JS	linux1804-64-shippable-qr	fission	1,617,422.00 -> 1,599,008.00

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=34672

Acasandrei Beatrice (needinfo me)

Updated

•

2 years ago

Keywords: perf-alert

Comment hidden (Intermittent Failures Robot)