1776235 - Change UI in protections panel when all ETP features are turned off

Status: NEW

(Core :: Privacy: Anti-Tracking, enhancement, P5)

Description

[soredake]

Attachment: ETP is disabled

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:101.0) Gecko/20100101 Firefox/101.0

Steps to reproduce:

I disabled "Enhanced Tracking Protection" in settings yet it's icon is still for every site in url-bar, and when i click on it it says that ETP is enabled.

Actual results:

ETP icon is show even when it's disabled.

Expected results:

No icon should show when ETP is disabled.

Comment 1

[soredake]

Attachment: Icon and it's menu still shows when ETP is disabled and claiming it's enabled for this site

Comment 2

[Ina Popescu, Desktop QA]

I've managed to reproduce this issue on the latest versions Nightly 103.0a1 and Firefox 102.0 on Windows x64.
Setting this to NEW. If this is not the right component, please move it to a more appropriate one.

Comment 3

[Emma Zühlcke [:emz]]

I'd argue there is still value in the protections panel, even if you have all user-facing features disabled.
Firstly there are features that are not controllable via the "custom" section in preferences (for example query param stripping). Users still need to be able to turn all protections off on a per-site basis in case they run into site-breakage.
Secondly, we still run classification so we can still display a list of trackers as in "these trackers would have been blocked but have been allowed to load since you don't have the feature enabled".

I'm leaning towards calling this a WONTFIX. Ben, what do you think?

Comment 4

[Benjamin VanderSloot [:bvandersloot]]

I agree that the shield should not go away under the preferences set above for the reasons you describe.

Perhaps we should consider a "Disabled" option in the UI so that users can opt out? It seems like a bit of a footgun, but I think if it is the last option and we put some warning text in, it may be a good thing to have for this use case. Thoughts?

Comment 5

[Emma Zühlcke [:emz]]

I don't see a good way to do this currently with some ETP (or closely ETP related) features not able to be turned off. But let's keep this bug for when that changes and there is a better defined "off" state.