1776367 - Add frame pointer to RegExp stubs

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Jan de Mooij [:jandem]]

The RegExp{Matcher,Searcher,Tester} stubs and regular expression JIT code don't have their own frame pointer. This means that when we call a regular expression from Ion code, we don't see this Ion frame in perf + jitdump profiles.

We can fix this by adding a frame pointer to these stubs. This also lets us simplify the code a bit because we can use the frame pointer to access stack slots.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1776367 part 1 - Annotate RegExp code for perf/VTune. r?iain!

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1776367 part 2 - Add frame pointer to RegExp stubs. r?iain!

This improves profiling with "perf" a bit because we now don't lose the Ion frame
anymore. It also lets us simplify the code because we can now use the frame pointer
instead of the stack pointer (less stable due to stack pushes).

Depends on D150223

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec1f18778d50
part 1 - Annotate RegExp code for perf/VTune. r=iain
https://hg.mozilla.org/integration/autoland/rev/b6c4f07384e0
part 2 - Add frame pointer to RegExp stubs. r=iain

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/ec1f18778d50
https://hg.mozilla.org/mozilla-central/rev/b6c4f07384e0