177637 - mfcEmbed painting problem when closing some windows entirely contained browserview

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Jeff Doozan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2b) Gecko/20021028 K-Meleon
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2b) Gecko/20021028 K-Meleon

When "some" windows are moved on top of mfcEmbed, and subsequently closed while
the mouse is also within the mfcEmbed window, the region covered by the window
is not repainted (or perhaps, is repainted, and then erased)

Reproducible: Always

Steps to Reproduce:
1) Open mfcEmbed
2) Maximize it
3) Run internet explorer
4) Rezise the IE window so that it is smaller than the mfcEmbed window
5) move the IE window on top of the mfcEmbed window, and entirely contained
within the browserview
6) Use the mouse to close the IE window


Actual Results:  
The area covered by the window is blank.

Expected Results:  
The area covered by the window should be visible.


Now, here's the rub:

1) it only happens with some windows (notepad, for example, behaves fine on my
machine while trillian chat windows behave the same as IE)
2) it does not happen if you use the keyboard (Alt+F4) to close the window while
the mouse cursor is not on top of the IE window

I suspect this is a race condition somewhere between the mousemove message that
is sent when the window is closed (WM_MOUSEMOVE), and the WM_PAINT message sent
when the window is destroyed.

Comment 1

[Jeff Doozan]

Screenshots available here:

<a href="http://www.tcbmi.com/mozilla/177637/before.jpg">Before</a>

<a href="http://www.tcbmi.com/mozilla/177637/after.jpg">After</a>

Comment 2

[Adam Lock]

Confirming.

It appears to be because the parent of the browser window is not clipping its
children. Patch follows.

Comment 3

[Adam Lock]

Attachment: Simple patch

1-line patch enables WS_CLIPCHILDREN on the browser view class.

Chak can you review please?

Comment 4

[Jeff Doozan]

The patch works flawlessly, great work Adam.  It's nice to see that it ended up
being something simple.

r=[e-mail]

Comment 5

[Chak Nanga]

For whatever it's worth (r=chak) since jeff already beat me to it :-)

Comment 6

[Adam Lock]

Comment on attachment 104814 [details] [diff] [review]
Simple patch

r=[e-mail]
r=[e-mail]

Comment 7

[Christopher Blizzard (:blizzard)]

Comment on attachment 104814 [details] [diff] [review]
Simple patch

rs=blizzard

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 104814 [details] [diff] [review]
Simple patch

a=asa for checkin to 1.2 (on behalf of drivers)

Comment 9

[Adam Lock]

Fix checked in