Closed
Bug 1776408
Opened 2 years ago
Closed 2 years ago
Move colorways to use mjs files, rather than defining sourceType for ESLint
Categories
(Firefox :: Theme, task)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
104 Branch
Tracking | Status | |
---|---|---|
firefox104 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
With the transition to using ES modules rather than JSMs getting started, we are now using the .mjs extension for those files.
I'd like to transition our content code that is using modules to use the .mjs extension as well - the primary gains of this are that we a) don't need to manually specify sourceType: module for ESLint, b) this gives a visual distinction to developers that the file is a module rather than a regular JavaScript file.
In the colorways code, we have ColorwayClosetSelector.js
which is loaded as a module, and colorwaycloset.js
which is not, despite ESLint being told they both are.
I'll therefore only move ColorwayClosetSelector.js
to be .mjs
.
Assignee | ||
Comment 1•2 years ago
|
||
Depends on D150238
Updated•2 years ago
|
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Updated•2 years ago
|
Attachment #9282780 -
Attachment description: Bug 1776408 - Move colorways to use mjs files, rather than defining sourceType for ESLint. r?dao → Bug 1776408 - Remove unused .eslintrc.js file from colorways code. r?dao
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/055aca641fcf Remove unused .eslintrc.js file from colorways code. r=dao
Comment 3•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox104:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•