Closed Bug 1776458 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 34584 - Fix some css/css-shapes tests that failed due to value precision

Categories

(Core :: Layout: Floats, task, P4)

task

Tracking

()

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(4 files)

Sync web-platform-tests PR 34584 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34584
Details from upstream follow.

Xianzhu Wang <wangxianzhu@chromium.org> wrote:

Fix some css/css-shapes tests that failed due to value precision

Previously these tests failed on both Chrome and Firefox because the
computed values of some css properties were slightly different from
the expected values. Now add function roundComputedCssNumber() to
round to 6 significant digits following the spec
https://drafts.csswg.org/cssom/#serializing-css-values.

Bug: 1129522
Change-Id: If84bf75f54d931eb40c38065d0d05cefd54f08d6
Reviewed-on: https://chromium-review.googlesource.com/3722705
WPT-Export-Revision: 5e85e9e764f1fc65fb3fcce0e26bcdc416ad772a

Component: web-platform-tests → Layout: Floats
Product: Testing → Core
Attached file Notable wpt changes
# CI Results Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 61 tests and 4 subtests ## Status Summary ### Firefox `OK` : 61 `PASS`: 3398 `FAIL`: 1271 ### Chrome `OK` : 61 `PASS`: 4551 `FAIL`: 118 ### Safari `OK` : 61 `PASS`: 4662 `FAIL`: 7 ## Links [GitHub PR Head](https://wpt.fyi/results/?sha=b56ea2414c55db676080b268a6cbfc4926acdd86&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=b56ea2414c55db676080b268a6cbfc4926acdd86&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes
# CI Results Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 61 tests and 4 subtests ## Status Summary ### Firefox `OK` : 61 `PASS`: 3398 `FAIL`: 1271 ### Chrome `OK` : 61 `PASS`: 4551 `FAIL`: 118 ### Safari `OK` : 61 `PASS`: 4662 `FAIL`: 7 ## Links [GitHub PR Head](https://wpt.fyi/results/?sha=b56ea2414c55db676080b268a6cbfc4926acdd86&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=b56ea2414c55db676080b268a6cbfc4926acdd86&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes
# CI Results Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 61 tests and 4 subtests ## Status Summary ### Firefox `OK` : 60[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 61[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub] `PASS`: 2968[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 3397[Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 3398[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, GitHub] `FAIL`: 817[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 1271[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, GitHub] 1272[Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] ### Chrome `OK` : 61 `PASS`: 4551 `FAIL`: 118 ### Safari `OK` : 61 `PASS`: 4662 `FAIL`: 7 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=7bb38e4ed8d7431d1295dfcd3757685d52ea17b8) [GitHub PR Head](https://wpt.fyi/results/?sha=b56ea2414c55db676080b268a6cbfc4926acdd86&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=b56ea2414c55db676080b268a6cbfc4926acdd86&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes
# CI Results Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 61 tests and 4 subtests ## Status Summary ### Firefox `OK` : 60[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 61[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub] `PASS`: 2968[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 3397[Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 3398[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, GitHub] `FAIL`: 817[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 1271[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, GitHub] 1272[Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] ### Chrome `OK` : 61 `PASS`: 4551 `FAIL`: 118 ### Safari `OK` : 61 `PASS`: 4662 `FAIL`: 7 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=7bb38e4ed8d7431d1295dfcd3757685d52ea17b8) [GitHub PR Head](https://wpt.fyi/results/?sha=b56ea2414c55db676080b268a6cbfc4926acdd86&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=b56ea2414c55db676080b268a6cbfc4926acdd86&label=pr_base) ## Details (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c182ca247a9a [wpt PR 34584] - Fix some css/css-shapes tests that failed due to value precision, a=testonly https://hg.mozilla.org/integration/autoland/rev/9e1e9eb43f57 [wpt PR 34584] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: