Deprecate Feature.enabled in NimbusFeatures for FxMS
Categories
(Firefox :: Nimbus Desktop Client, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox104 | --- | fixed |
People
(Reporter: barret, Assigned: barret)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files)
The FxMS features need to support A/B testing where one of the branches is disabled. ASRouter already supports this (any message without an id will be dropped and not ingested), but when we remove support for Feature.enabled, they will fail validation, so the schemas need to be updated to allow an empty value which will result in no message being loaded.
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 1•2 years ago
|
||
Now that we have fixed our FxMS schemas in bug 1771073, we can start to tighten
up our schemas again. Specifically, we need to be able to accept an empty
message object to support the removal of Feature.enabled in Nimbus.
Depends on D150689
|
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D150690
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/95bf9b6e27c8 Remove test_schemas_backwards_compat r=emcminn https://hg.mozilla.org/integration/autoland/rev/8fe694b12df5 Support empty messages in the FxMS experiment schema r=emcminn
|
||
Comment 4•2 years ago
|
||
Backed out as requested.
Backout by abutkovits@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ee5cb4327473 Backed out changeset 8fe694b12df5 as requested by Barret. CLOSED TREE
|
|
||
Comment 6•2 years ago
•
|
||
Update:
Failure log: https://treeherder.mozilla.org/logviewer?job_id=384007521&repo=autoland&lineNumber=4728
(I believe the above backout should fix this)
|
|
Assignee | |
Comment 7•2 years ago
|
||
Backout fixed it, will address when re-landding.
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e2ab896c9681 Support empty messages in the FxMS experiment schema r=emcminn
|
|
||
Comment 9•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/95bf9b6e27c8
https://hg.mozilla.org/mozilla-central/rev/e2ab896c9681
|
|
Assignee | |
Updated•2 years ago
|
Description
•