1776484 - [wpt-sync] Sync PR 34586 - Reland "Add TimedHTMLParserBudget to fieldtrial_testing_config.json"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 34586 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34586
Details from upstream follow.

Clark DuVall <[e-mail]> wrote:

Reland "Add TimedHTMLParserBudget to fieldtrial_testing_config.json"

This is a reland of commit 8538a928dc7750dfa8a3fe1661e518f86882995b

This adds a couple more fixes to tests that were failing on the MSan
bot, see crbug.com/1339319. Changes from original are from patchset
1 on.

Original change's description:

Add TimedHTMLParserBudget to fieldtrial_testing_config.json

This exposed cases where some web_tests were implicitly depending on
the parser yielding at specific times. The fixes here should make
these tests less brittle in general.

These issues can be reproduced with the current token based parser
logic by inserting a bunch of \<span>s at certain places in the HTML
to force the parser to yield. The list of fixes:

• createImageBitmap-sizeOverflow.html: this test was just broken in
  general. It was not waiting for the assert_throws_dom code to run.
  The test is now fixed by switching to a promise_test.
• resource-selection-invoke-*: These tests were depending on not
  yielding between scripts. The check they had in the separate
  script was not very important and was brittle, and in the sync version
  was already failing (see FAIL in expectations file).
• track-selection-metadata.html: this test was depending on the parser
  not yielding after executing the script. This was fixed by moving
  the script outside the \<video> element.
• execution-timing/080.html: depended on the parser not yielding
  between scripts.
• about-blank-replacement-blank-nested-frame.html: depended on parser
  not yielding between scripts.
• fast/frames/*: exposed an existing bug where frame borders would not
  be drawn if the parser yields at certain times. Filed this at
  crbug.com/1338331. I fixed this by using CSS borders for the frames
  instead of frameborder.

Bug: 1314493
Change-Id: I8ad7708659bc9690be2641a22bf4d5f24165dc8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3716825
Reviewed-by: Mason Freed \<[e-mail]>
Commit-Queue: Clark DuVall \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1017439}

Bug: 1314493, 1339319
Change-Id: I5f21f6f12b34dab4ede2e99fa7c6aca75084db3f

Reviewed-on: https://chromium-review.googlesource.com/3723814
WPT-Export-Revision: 3249011fb38ddf4d181b1205a5a7c3c4ef9a9b08

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4312772ed0039e9e42c2a4c49dee9ef20ddb596e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests and 7 subtests

Status Summary

Firefox

OK : 7
PASS : 31
FAIL : 3
TIMEOUT: 1
NOTRUN : 1

Chrome

OK : 8
PASS : 28
FAIL : 7

Safari

OK : 7
PASS : 17
FAIL : 17
TIMEOUT: 1
NOTRUN : 1

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /content-security-policy/style-src/style-src-inline-style-nonce-blocked-error-event.html [wpt.fyi]
  • Should fire a securitypolicyviolation event: FAIL

New Tests That Don't Pass

• /content-security-policy/style-src/style-src-inline-style-nonce-blocked-error-event.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Should fire a securitypolicyviolation event: FAIL (Chrome: PASS, Safari: PASS)
  • Test that paragraph remains unmodified and error events received.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
• /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-in-sync-event.html [wpt.fyi]
  • await a stable state and sync event handlers: FAIL (Chrome: FAIL, Safari: FAIL)
• /navigation-api/ordering-and-transition/navigate-cross-document-double.html [wpt.fyi]
  • event and promise ordering when navigate() is called to a cross-document destination, interrupting another navigate() to a cross-document destination: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fcee4f11ea2
[wpt PR 34586] - Reland "Add TimedHTMLParserBudget to fieldtrial_testing_config.json", a=testonly

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/2fcee4f11ea2