Closed Bug 1776513 Opened 3 months ago Closed 3 months ago

Implement Merino session IDs

Categories

(Firefox :: Address Bar, task, P1)

task
Points:
3

Tracking

()

VERIFIED FIXED
104 Branch
Tracking Status
firefox104 --- verified

People

(Reporter: adw, Assigned: adw)

References

Details

Attachments

(1 file)

This implements Merino session IDs and sequence numbers. Please see
https://mozilla-hub.atlassian.net/browse/SUGGEST-295 for details.

In summary, each request to Merino should include a session ID and a per-session
sequence number. Session IDs should be cleared at the end of engagements.

I added two new tests, a browser smoke test to make sure engagements happen as
expected in the browser and an xpcshell test for deeper testing.

Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5afcc7d07966
Implement Merino session IDs. r=daisuke
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch

STR for QA

  1. Set browser.urlbar.quicksuggest.dataCollection.enabled to true
  2. Open the Network tab in the Browser Toolbox and type "merino" in the filter text box to filter in Merino-related logs
  3. Type a few characters in the urlbar
  4. In the Browser Toolbox, verify requests were sent to Merino
  5. Verify the request URLs include sid=<UUID> and seq=<number> substrings. You can either look at the "File" column or click on individual log entries to see more info about the request including the individual sid and seq values.
  6. Verify the "<UUID>" is an actual UUID, a string like "{d3cfe334-000f-46c3-8ca2-2866841a40ff}"
  7. Verify the UUID values are the same in all URLs
  8. Verify the "<number>" values are generally increasing in value with each request. You may see some values that are the same, especially if you type quickly. That's expected.
  9. Switch back to the main browser window. If you did not move the focus to the Browser Toolbox window, then first move the focus out of the urlbar and then back into it.
  10. Repeat the steps starting from step 3 again. This time the UUID should be different from what it was before and the "<number>" value should start from zero again.
Flags: qe-verify+
Flags: in-testsuite+

I have verified this bug on the latest Nightly 104.0a1 build (Build ID: 20220629070023) on Windows 10 x64, macOS 12.4 and Ubuntu 20.04 x64.

  • In order to verify this bug I have followed the STR described in comment 5.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.