1776534 - removeFile('') and removeDirectory('') shouldn't assert

Status: RESOLVED FIXED

(Core :: DOM: File, defect, P3)

Description

[Randell Jesup [:jesup] (needinfo me)]

Trying to delete files with 0-length names (and directories) should return TypeError failures, not MOZ_ASSERT

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1776534: Fix removeFile/Directory('') to return an error r=jari,#dom-storage-reviewers

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jesup, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 3

[Jens Stutte [:jstutte]]

(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #2)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jesup, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Could the bot exclude patches that depend on other patches (in phabricator) from this kind of nagging?

Comment 4

[Suhaib Mujahid [:suhaib]]

(In reply to Jens Stutte [:jstutte] from comment #3)

Could the bot exclude patches that depend on other patches (in phabricator) from this kind of nagging?

Yes, the bot could do that. I filed an issue to follow up: https://github.com/mozilla/relman-auto-nag/issues/1625

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

This got rolled into another patch