Closed Bug 1776805 Opened 2 years ago Closed 2 years ago

Avoid including SimpleTest.js directly from APZ test helpers

Categories

(Core :: Panning and Zooming, task, P3)

task

Tracking

()

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: botond, Assigned: botond)

Details

Attachments

(1 file)

As discovered in https://phabricator.services.mozilla.com/D149925#4915942, doing this defeats the attempt in runSubtestsSeriallyInFreshWindows() to hook the various assertion functions to include the current subtest name.

Note, this is only applicable to helpers used directly as subtests
in runSubtestsSeriallyInFreshWindows(). It does not apply to:

  • Fission test helpers (helper_fission_*.html), which use a separate
    subtest mechanism

  • Helpers for browser mochitests

  • Helpers which are files loaded in an iframe by another helper

Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e4bcee7402a
Avoid including SimpleTest.js directly from APZ test helpers. r=dlrobertson
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: