1776837 - Reject lazy getters that are already imported eagerly

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Dave Townsend [:mossop]]

It can happen that a single jsm has multiple exports. If you're importing one of them eagerly then there is no point in doing lazy imports for the others. e.g. this pattern should be rejected:

const { UrlbarProvider } = ChromeUtils.import(
  "resource:///modules/UrlbarUtils.jsm"
);

const lazy = {};

XPCOMUtils.defineLazyModuleGetters(lazy, {
  UrlbarUtils: "resource:///modules/UrlbarUtils.jsm",
});

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1776837 - Part 1: Do not use lazy getter for eagerly loaded modules. r?mossop!

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1776837 - Part 2: Reject defining lazy getter for module that is already loaded eagerly at top-level. r?mossop!

Depends on D150935

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/176964039b97
Part 1: Do not use lazy getter for eagerly loaded modules. r=mossop,webdriver-reviewers,application-update-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/35fcac797332
Part 2: Reject defining lazy getter for module that is already loaded eagerly at top-level. r=mossop

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/176964039b97
https://hg.mozilla.org/mozilla-central/rev/35fcac797332