1777328 - Remove braces from Merino session IDs

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

Nan suggested the client should not include braces in Merino session IDs.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1777328 - Remove braces from Merino session IDs.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6880a8938c14
Remove braces from Merino session IDs. r=daisuke

Comment 3

[Drew Willcoxon :adw]

STR for QA

1. Set browser.urlbar.quicksuggest.dataCollection.enabled to true
2. Open the Network tab in the Browser Toolbox and type "merino" in the filter text box to filter in Merino-related logs
3. Type a few characters in the urlbar
4. In the Browser Toolbox, verify requests were sent to Merino
5. Verify the request URLs include sid=<UUID> substrings. You can either look at the "File" column or click on individual log entries to see more info about the request including the individual sid values.
6. Verify the "<UUID>" values are alphanumeric strings with -, and they do not include { and }. For example: 66252613-6877-4382-be75-88212e92c1ba

Comment 4

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/6880a8938c14

Comment 5

[Carmen Fat [:cfat] - Ecosystem QA]

We have verified this bug on the latest Nightly 104.0a1 build (Build ID: 20220630212430) on Windows 10 x64, macOS 12.4, and Ubuntu 20.04 x64.

• In order to verify this bug, we have followed the STR described in comment 3.
• We verified that requests are sent to Merino after enabling the Data Collection preference.
• We verified that "<UUID>" values are alphanumeric strings with -.
• We verified that "<UUID>" values do not contain { and } symbols.