Closed Bug 1777359 Opened 2 years ago Closed 2 years ago

Check OPFS removeEntry for invalid entry names

Categories

(Core :: DOM: File, defect, P3)

Product:
Core
Component:
DOM: File
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
firefox107 --- fixed

People

(Reporter: jesup, Assigned: jesup)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1777359: Fix issues with OPFS removeEntry and resolve (which errors are returned, invalid requests) r=jari,#dom-storage-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Names like ., .., /, etc aren't allowed and should return errors per the spec:
"A valid file name is a string that is not an empty string, is not equal to "." or "..", and does not contain '/' or any other character used as path separator on the underlying platform."

Blocks: 1777361
No longer blocks: 1777361
Severity: -- → S3
Priority: -- → P3
Attachment #9283526 - Attachment description: Bug 1777359: Fix issues with OPFS remove() (which errors are returned, invalid requests) r=jari,#dom-storage-reviewers → Bug 1777359: Fix issues with OPFS removeEntry() (which errors are returned, invalid requests) r=jari,#dom-storage-reviewers
Attachment #9283526 - Attachment description: Bug 1777359: Fix issues with OPFS removeEntry() (which errors are returned, invalid requests) r=jari,#dom-storage-reviewers → Bug 1777359: Fix issues with OPFS removeEntry and resolve (which errors are returned, invalid requests) r=jari,#dom-storage-reviewers
Attachment #9292993 - Attachment is obsolete: true
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/autoland/rev/27e5e6441cd5
Fix issues with OPFS removeEntry and resolve (which errors are returned, invalid requests) r=jari,dom-storage-reviewers
Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Backed out for causing xpcshell and gtest failures

Backout link

Push with failures - xpcshell
Push with failures - gtest

Failure log - xpcshell
Failure log - gtest

Flags: needinfo?(rjesup)
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/autoland/rev/4af19da55ce9
Fix issues with OPFS removeEntry and resolve (which errors are returned, invalid requests) r=jari,dom-storage-reviewers

https://hg.mozilla.org/mozilla-central/rev/4af19da55ce9

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox107: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36036 for changes under testing/web-platform/tests
Upstream PR merged by moz-wptsync-bot
Upstream PR merged by moz-wptsync-bot
Flags: needinfo?(rjesup)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: