1777365 - Fix incorrect OPFS WPT test that assumes data: URIs can't be secure

Status: RESOLVED FIXED

(Core :: DOM: File, defect, P3)

Description

[Randell Jesup [:jesup] (needinfo me)]

See https://mozilla.pettay.fi/moztests/data_url_isSecureContext.html
data url iframe + window.isSecureContext
It's not clear why Chrome returns false
"If the result of Is url potentially trustworthy? given environment's top-level creation URL is "Potentially Trustworthy", then return true."

The test is wrong:
See https://wpt.fyi/results/secure-contexts/basic-popup-and-iframe-tests.https.html?label=experimental&label=master&aligned
and Chrome folks agreed on the behavior Gecko has https://github.com/w3c/webappsec-secure-contexts/issues/69#issuecomment-585780599

In the wpt.fyi test, Chrome is failing in "Test Window.isSecureContext in an iframe loading a data: URL" test and "Test Window.isSecureContext in a sandboxed iframe loading a data: URL" test

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1777365: Fix opaque origin OPFS WPT test which assumes data: URIs can't be secure r=smaug

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jesup, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Up to jesup to land

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5816d39c37b2
Fix opaque origin OPFS WPT test which assumes data: URIs can't be secure r=smaug

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35858 for changes under testing/web-platform/tests

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing multiple lint failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/292d43f4f4d259a83975b0a6ea2ffee2f473b5e2

Push with failures

Failure log ESlint

Failure log py black

Failure log mozlint wpt

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/152e20bdfc5e
Fix opaque origin OPFS WPT test which assumes data: URIs can't be secure r=smaug

Comment 8

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing wpt failures . CLOSED TREE
Backout link
Push with failures
Link to failure log 1
Link to failure log 2
Failure line 1 : TEST-UNEXPECTED-FAIL | /fs/FileSystemDirectoryHandle-removeEntry.https.any.worker.html | removeEntry() while the file has an open writable fails - promise_test: Unhandled rejection with value: object "TypeError: navigator.storage.getDirectory is not a function"
Failure line 2 : TEST-UNEXPECTED-FAIL | /fs/FileSystemDirectoryHandle-removeEntry.https.any.html | removeEntry() while the file has an open writable fails - promise_test: Unhandled rejection with value: object "TypeError: navigator.storage.getDirectory is not a function"

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f14ea4093d57
Fix opaque origin OPFS WPT test which assumes data: URIs can't be secure r=smaug

Comment 10

[Norisz Fay [:noriszfay]]

Backed out for causing FileSystem related wpt failures

Backout link

Push with failures

Failure log

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4838c8b7e5f4
Fix opaque origin OPFS WPT test which assumes data: URIs can't be secure r=smaug

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/4838c8b7e5f4

Comment 13

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot