Closed Bug 1777484 Opened 3 years ago Closed 2 years ago

Extension widgets in the unified extensions panel should behave like the other extension items

Categories

(WebExtensions :: General, enhancement, P2)

Product:
WebExtensions
Component:
General
Type:
enhancement

Tracking

(firefox109 fixed)

Status:
RESOLVED FIXED
Milestone:
109 Branch
Tracking Flags:
Tracking Status
firefox109 --- fixed

People

(Reporter: zombie, Assigned: willdurand)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [addons-jira])

Attachments

(2 files, 2 obsolete files)

Bug 1777484 - Allow to close unified extensions panel programmatically. r?Gijs!,rpl
48 bytes, text/x-phabricator-request
Details | Review
Bug 1777484 - Enhance extension widgets in the unified extensions panel. r?rpl!,Itiel!
48 bytes, text/x-phabricator-request
Details | Review

Clicking the extension row acts as the action button click:

  • closes the panel, and
  • opens the extension popup (if any)
  • (stretch) temporarily turns icon into extension's while popup is open
Depends on: 1777481
Whiteboard: [addons-jira]
Severity: -- → N/A
Priority: -- → P2

This patch is needed because we want to toggle the panel programatically
in the future and I noticed that the previous toggling didn't work as
expected. This is because PanelUI uses a temporary panel 1 when
there is none already existing.

This patch adds a panel and multipanelview with (hopefully) all the
right attributes (it mimics what PanelUI does in a way). The tests
have been updated to rely on togglePanel() so that we have some
coverage (it was still working without the changes in the test file).

Assignee: nobody → wdurand
Status: NEW → ASSIGNED
Attachment #9286439 - Attachment description: Bug 1777484 - Use multipaneleview explicitely. r?Itiel!,rpl → Bug 1777484 - Use multipanelview explicitely. r?Itiel!,rpl
Attachment #9286439 - Attachment description: Bug 1777484 - Use multipanelview explicitely. r?Itiel!,rpl → Bug 1777484 - Use multipanelview explicitly. r?Itiel!,rpl
Attachment #9286439 - Attachment description: Bug 1777484 - Use multipanelview explicitly. r?Itiel!,rpl → Bug 1777484 - Use multipanelview explicitly. r?mstriemer!,rpl
Attachment #9286439 - Attachment description: Bug 1777484 - Use multipanelview explicitly. r?mstriemer!,rpl → Bug 1777484 - Allow to close unified extensions panel programatically. r?Gijs!,rpl
Attachment #9286439 - Attachment description: Bug 1777484 - Allow to close unified extensions panel programatically. r?Gijs!,rpl → Bug 1777484 - Allow to close unified extensions panel programmatically. r?Gijs!,rpl
Keywords: leave-open
Pushed by bszekely@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/d49cd6d75da0 Allow to close unified extensions panel programmatically. r=rpl,Gijs
Attachment #9286453 - Attachment description: WIP: Bug 1777484 - Trigger extension action on item click. → Bug 1777484 - Trigger extension action on item click. r?rpl!,Jamie
Attachment #9286453 - Attachment description: Bug 1777484 - Trigger extension action on item click. r?rpl!,Jamie → Bug 1777484 - Part 1 - Trigger extension action on item click. r?rpl!,Jamie

Depends on D152407

Attachment #9288122 - Attachment description: WIP: Bug 1777484 - Part 2 - Open extension popups on item click. r?rpl!,Jamie → Bug 1777484 - Part 2 - Open extension popups on item click. r?rpl!,Jamie
Attachment #9288122 - Attachment description: Bug 1777484 - Part 2 - Open extension popups on item click. r?rpl!,Jamie → Bug 1777484 - Part 2 - Open extension popups on item click. r?rpl!
Attachment #9286453 - Attachment is obsolete: true
Attachment #9288122 - Attachment is obsolete: true
Depends on: 1784947
Duplicate of this bug: 1794509
Summary: Clicking on the item in Extension button panel should behave like action button click → Extension widgets in the unified extensions panel should behave like the other extension items

I am going to use this bug to finish the implementation of the extension widgets in the new unified extensions panel. Technically, we already support custom icons, badges and click events/popups thanks to Bug 1784947 but some of the features of the extension "items" (the extensions without browser actions) in the panel are missing, and that's what I am going to fix here.

Attachment #9301802 - Attachment description: WIP: Bug 1777484 - Enhance extension widgets in the unified extensions panel. r?rpl! → Bug 1777484 - Enhance extension widgets in the unified extensions panel. r?rpl!
Attachment #9301802 - Attachment description: Bug 1777484 - Enhance extension widgets in the unified extensions panel. r?rpl! → WIP: Bug 1777484 - Enhance extension widgets in the unified extensions panel. r?rpl!
Attachment #9301802 - Attachment description: WIP: Bug 1777484 - Enhance extension widgets in the unified extensions panel. r?rpl! → Bug 1777484 - Enhance extension widgets in the unified extensions panel. r?rpl!,Itiel!
Blocks: 1799694
Blocks: 1799832
Duplicate of this bug: 1777344
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/75eba3b7a626 Enhance extension widgets in the unified extensions panel. r=rpl,Itiel

Backed out along with Bug 1782203 for causing failures on browser_unified_extensions_overflowable_toolbar.js

Pushed by wdurand@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f194b65a8c43 Enhance extension widgets in the unified extensions panel. r=rpl,Itiel

Atila, we can actually close this bug.

Flags: needinfo?(abutkovits)
Keywords: leave-open
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox109: --- → fixed
Flags: needinfo?(abutkovits)
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
Blocks: 1800881
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: