1777487 - Only query active StreamFilters if webRequestBlocking permission is granted and prevent race with extension shutdown

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, defect, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

While investigating Bug 1774497 TV intermittent failure, we have noticed that we could restrict the call to ParentAPIManager.queryStreamFilterSuspendCancel to the extensions that have a webRequestBlocking permission granted.

In addition to that, I investigate the race that Bug 1774497 caught (which I was able to also trigger locally on an android x86 debug build by using --verify and --disable-fission mach xpcshell-test cli options) because skipping the call to queryStreamFilterSuspendCancel for extensions without the "webRequestBlocking" permission was going to hide that and there were actually two kind of errors that the race between the call to queryStreamFilterSuspendCancel to be resolved and the extension being shutdown in the meantime:

• ExtensionParent.ParentAPIManager.queryStreamFilterSuspendCancel may reject with an AbortError if the extension shutdown before the returned promise is resolved
• this.extension may be nullified by the time we are going to call this.onShutdown(false) nearby the end of the terminateBackground async function

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1777487 - Only query active StreamFilters if webRequestBlocking permission is granted and prevent race with extension shutdown. r?mixedpuppy!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/205ee354f198
Only query active StreamFilters if webRequestBlocking permission is granted and prevent race with extension shutdown. r=mixedpuppy

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/205ee354f198