1777517 - [Cooca] Add some log around clipboard operation

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, enhancement, P3)

Description

[Edgar Chen [:edgar]]

There are some loggings on clipboard in GTK widget, like https://searchfox.org/mozilla-central/rev/4654ce1e24a6af17bc96ab60f1f70c218755142f/widget/gtk/nsClipboard.cpp#645-662, I found they are really helpful while developing/debugging the clipboard stuff. So in this bug I would like to add similar log in Cocoa widget. And probably file other bugs for other platform.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug 1777517 - [Cocoa] Add clipboard logs; r?NeilDeakin

Comment 2

[bszekely]

Backed out for causing build bustages on Unified_cpp_widget_windows2.obj

Failure line: gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:667: Unified_cpp_widget_windows2.obj] Error 1

Push with failures

Failure log

Backout link

[task 2022-07-04T12:32:33.535Z] 12:32:33     INFO -  In file included from Unified_cpp_widget_windows2.cpp:2:
[task 2022-07-04T12:32:33.535Z] 12:32:33     INFO -  In file included from /builds/worker/checkouts/gecko/widget/windows/nsDataObj.cpp:15:
[task 2022-07-04T12:32:33.535Z] 12:32:33     INFO -  In file included from /builds/worker/checkouts/gecko/widget/windows/nsClipboard.h:9:
[task 2022-07-04T12:32:33.535Z] 12:32:33     INFO -  /builds/worker/checkouts/gecko/widget/nsBaseClipboard.h(13,17): error: no type named 'LazyLogModule' in namespace 'mozilla'
[task 2022-07-04T12:32:33.535Z] 12:32:33     INFO -  static mozilla::LazyLogModule sWidgetClipboardLog("WidgetClipboard");
[task 2022-07-04T12:32:33.535Z] 12:32:33     INFO -         ~~~~~~~~~^
[task 2022-07-04T12:32:33.535Z] 12:32:33     INFO -  1 error generated.
[task 2022-07-04T12:32:33.535Z] 12:32:33    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:667: Unified_cpp_widget_windows2.obj] Error 1
[task 2022-07-04T12:32:33.535Z] 12:32:33     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/widget/windows'
[task 2022-07-04T12:32:33.535Z] 12:32:33     INFO -  gmake[4]: *** Waiting for unfinished jobs....
[task 2022-07-04T12:32:33.591Z] 12:32:33     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/testing/tools/screenshot'
[task 2022-07-04T12:32:33.591Z] 12:32:33     INFO -  /builds/worker/workspace/obj-build/_virtualenvs/build/bin/python /builds/worker/checkouts/gecko/build/win32/autowinchecksec.py ../../../dist/bin/screenshot.exe
[task 2022-07-04T12:32:33.591Z] 12:32:33     INFO -  TEST-PASS | autowinchecksec.py | ../../../dist/bin/screenshot.exe succeeded
[task 2022-07-04T12:32:33.592Z] 12:32:33     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/testing/tools/screenshot'
[task 2022-07-04T12:32:33.605Z] 12:32:33     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/media/ffvpx/libavutil'
[task 2022-07-04T12:32:33.606Z] 12:32:33     INFO -  /builds/worker/workspace/obj-build/_virtualenvs/build/bin/python /builds/worker/checkouts/gecko/build/win32/autowinchecksec.py mozavutil.dll
[task 2022-07-04T12:32:33.607Z] 12:32:33     INFO -  TEST-PASS | autowinchecksec.py | mozavutil.dll succeeded
[task 2022-07-04T12:32:33.607Z] 12:32:33     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/media/ffvpx/libavutil'
[task 2022-07-04T12:32:33.611Z] 12:32:33     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/testing/tools/minidumpwriter'
[task 2022-07-04T12:32:33.612Z] 12:32:33     INFO -  /builds/worker/workspace/obj-build/_virtualenvs/build/bin/python /builds/worker/checkouts/gecko/build/win32/autowinchecksec.py ../../../dist/bin/minidumpwriter.exe
[task 2022-07-04T12:32:33.613Z] 12:32:33     INFO -  TEST-PASS | autowinchecksec.py | ../../../dist/bin/minidumpwriter.exe succeeded
[task 2022-07-04T12:32:33.613Z] 12:32:33     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/testing/tools/minidumpwriter'
[task 2022-07-04T12:32:33.618Z] 12:32:33     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/memory/replace/logalloc/replay'
[task 2022-07-04T12:32:33.618Z] 12:32:33     INFO -  /builds/worker/workspace/obj-build/_virtualenvs/build/bin/python /builds/worker/checkouts/gecko/build/win32/autowinchecksec.py ../../../../dist/bin/logalloc-replay.exe
[task 2022-07-04T12:32:33.619Z] 12:32:33     INFO -  TEST-PASS | autowinchecksec.py | ../../../../dist/bin/logalloc-replay.exe succeeded
[task 2022-07-04T12:32:33.619Z] 12:32:33     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/memory/replace/logalloc/replay'
[task 2022-07-04T12:32:33.626Z] 12:32:33     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/build/win32'
[task 2022-07-04T12:32:33.627Z] 12:32:33     INFO -  /builds/worker/workspace/obj-build/_virtualenvs/build/bin/python /builds/worker/checkouts/gecko/build/win32/autowinchecksec.py ../../dist/bin/crashinject.exe
[task 2022-07-04T12:32:33.627Z] 12:32:33     INFO -  TEST-PASS | autowinchecksec.py | ../../dist/bin/crashinject.exe succeeded
[task 2022-07-04T12:32:33.627Z] 12:32:33     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/build/win32'
[task 2022-07-04T12:32:33.627Z] 12:32:33     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/build/win32/crashinjectdll'
[task 2022-07-04T12:32:33.628Z] 12:32:33     INFO -  /builds/worker/workspace/obj-build/_virtualenvs/build/bin/python /builds/worker/checkouts/gecko/build/win32/autowinchecksec.py crashinjectdll.dll
[task 2022-07-04T12:32:33.628Z] 12:32:33     INFO -  TEST-PASS | autowinchecksec.py | crashinjectdll.dll succeeded
[task 2022-07-04T12:32:33.628Z] 12:32:33     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/build/win32/crashinjectdll'
[task 2022-07-04T12:32:33.628Z] 12:32:33     INFO -  gmake[4]: Nothing to be done for 'syms'.
[task 2022-07-04T12:32:33.638Z] 12:32:33     INFO -  gmake[4]: Nothing to be done for 'syms'.
[task 2022-07-04T12:32:33.643Z] 12:32:33     INFO -  gmake[4]: Nothing to be done for 'syms'.
[task 2022-07-04T12:32:33.646Z] 12:32:33     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/media/gmp-plugin-openh264'
[task 2022-07-04T12:32:33.646Z] 12:32:33     INFO -  /builds/worker/workspace/obj-build/_virtualenvs/build/bin/python /builds/worker/checkouts/gecko/build/win32/autowinchecksec.py fakeopenh264.dll
[task 2022-07-04T12:32:33.647Z] 12:32:33     INFO -  TEST-PASS | autowinchecksec.py | fakeopenh264.dll succeeded
[task 2022-07-04T12:32:33.647Z] 12:32:33     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/media/gmp-plugin-openh264'
[task 2022-07-04T12:32:33.648Z] 12:32:33     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/media/fake-cdm'
[task 2022-07-04T12:32:33.648Z] 12:32:33     INFO -  /builds/worker/workspace/obj-build/_virtualenvs/build/bin/python /builds/worker/checkouts/gecko/build/win32/autowinchecksec.py fake.dll
[task 2022-07-04T12:32:33.649Z] 12:32:33     INFO -  TEST-PASS | autowinchecksec.py | fake.dll succeeded
[task 2022-07-04T12:32:33.649Z] 12:32:33     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/media/fake-cdm'
[task 2022-07-04T12:32:33.651Z] 12:32:33     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/components/ctypes/tests'
[task 2022-07-04T12:32:33.652Z] 12:32:33     INFO -  /builds/worker/workspace/obj-build/_virtualenvs/build/bin/python /builds/worker/checkouts/gecko/build/win32/autowinchecksec.py jsctypes-test.dll
[task 2022-07-04T12:32:33.652Z] 12:32:33     INFO -  TEST-PASS | autowinchecksec.py | jsctypes-test.dll succeeded
[task 2022-07-04T12:32:33.652Z] 12:32:33     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/ctypes/tests'
[task 2022-07-04T12:32:33.674Z] 12:32:33     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/mozglue/build'
[task 2022-07-04T12:32:33.674Z] 12:32:33     INFO -  /builds/worker/workspace/obj-build/_virtualenvs/build/bin/python /builds/worker/checkouts/gecko/build/win32/autowinchecksec.py mozglue.dll
[task 2022-07-04T12:32:33.674Z] 12:32:33     INFO -  TEST-PASS | autowinchecksec.py | mozglue.dll succeeded
[task 2022-07-04T12:32:33.674Z] 12:32:33     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/mozglue/build'
[task 2022-07-04T12:32:33.678Z] 12:32:33     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/security/manager/ssl/ipcclientcerts/dynamic-library'
[task 2022-07-04T12:32:33.679Z] 12:32:33     INFO -  /builds/worker/workspace/obj-build/_virtualenvs/build/bin/python /builds/worker/checkouts/gecko/build/win32/autowinchecksec.py ipcclientcerts.dll
[task 2022-07-04T12:32:33.680Z] 12:32:33     INFO -  TEST-PASS | autowinchecksec.py | ipcclientcerts.dll succeeded
[task 2022-07-04T12:32:33.680Z] 12:32:33     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/security/manager/ssl/ipcclientcerts/dynamic-library'
[task 2022-07-04T12:32:33.710Z] 12:32:33     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/components/aboutthirdparty/tests/TestShellEx'
[task 2022-07-04T12:32:33.710Z] 12:32:33     INFO -  /builds/worker/workspace/obj-build/_virtualenvs/build/bin/python /builds/worker/checkouts/gecko/build/win32/autowinchecksec.py TestShellEx.dll
[task 2022-07-04T12:32:33.711Z] 12:32:33     INFO -  TEST-PASS | autowinchecksec.py | TestShellEx.dll succeeded
[task 2022-07-04T12:32:33.711Z] 12:32:33     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/aboutthirdparty/tests/TestShellEx'
[task 2022-07-04T12:32:35.188Z] 12:32:35     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/widget/windows'

Comment 3

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=44ec8f6bcc84654087b26bf48367da89350759a2

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c31b9078d3d7