Closed Bug 1777599 Opened 9 months ago Closed 9 months ago

Rename all instances of __searchForm to _cachedSearchForm within SearchEngine.jsm

Categories

(Firefox :: Search, task, P2)

Product:
Firefox
Component:
Search
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
104 Branch
Tracking Flags:
Tracking Status
firefox104 --- fixed

People

(Reporter: mcheang, Assigned: mcheang)

References

(
URL
)

Details

Attachments

(1 file)

Bug 1777599 - rename all instances of __searchForm to _cachedSearchForm for clarity. r=Standard8
48 bytes, text/x-phabricator-request
Details | Review

As part of Search Management Improvements and Refactors,
I am changing all instances of __searchForm to _cachedSearchForm.

The use of the double underscore for __searchForm means the search form is cached. This double underscore convention is not documented and can be confusing for anyone who is unaware of what the double underscore represents in our code. Thus, _cachedSearchForm is a more clear and explicit variable name.

Blocks: 1777632
Severity: -- → N/A
Pushed by mcheang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/466587798443
rename all instances of __searchForm to _cachedSearchForm for clarity. r=Standard8

https://hg.mozilla.org/mozilla-central/rev/466587798443

Status: NEW → RESOLVED
Closed: 9 months ago
status-firefox104: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.