1777886 - Check that denylist files actually exist in startup perf tests

Status: RESOLVED FIXED

(Firefox :: General, task)

Description

[Kris Maglione [:kmag]]

Sometimes a file in one of the startup performance deny lists is renamed, and later starts getting loaded in a phase it was supposed to be banned from under a new name. Other times, less problematically, files are just removed, and the entries remain as unnecessary dead code.

It's easy enough to check that the files exist, so we should do that, and any entries that are renamed should be renamed in the deny list, or removed, with the appropriate review.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1777886 - Check that denylist/intermittent files actually exist in startup perf tests. r=florian

This will require that entries for renamed files be updated so that they don't
accidentally start being loaded under the new name later. It also prevents
dead code entries from sticking around after their targets are removed.

Using throttledMapPromises is probably not strictly necessary given the
small number of entries in most lists, but since it already exists, we may as
well use it here.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/558ec2a25702
Check that denylist/intermittent files actually exist in startup perf tests. r=florian

Comment 3

[Iulian Moraru]

Backed out for failures on browser_startup.js.

Push with failures

Failure log

Backout link

[task 2022-07-07T23:05:09.016Z] 23:05:09     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup.js | denylist entry resource://gre/modules/ContextualIdentityService.jsm for phase "before handling user events" must exist - 
[task 2022-07-07T23:05:09.017Z] 23:05:09     INFO - TEST-INFO | started process screentopng
[task 2022-07-07T23:05:09.235Z] 23:05:09     INFO - TEST-INFO | screentopng: exit 0
[task 2022-07-07T23:05:09.236Z] 23:05:09     INFO - Buffered messages logged at 23:05:08
[task 2022-07-07T23:05:09.237Z] 23:05:09     INFO - Entering test bound 
[task 2022-07-07T23:05:09.237Z] 23:05:09     INFO - Buffered messages finished
[task 2022-07-07T23:05:09.237Z] 23:05:09     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup.js | denylist entry resource://gre/modules/CrashSubmit.jsm for phase "before handling user events" must exist - 
[task 2022-07-07T23:05:09.237Z] 23:05:09     INFO - Stack trace:
[task 2022-07-07T23:05:09.237Z] 23:05:09     INFO - chrome://mochikit/content/browser-test.js:test_ok:1401
[task 2022-07-07T23:05:09.237Z] 23:05:09     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup.js:null:228
[task 2022-07-07T23:05:09.238Z] 23:05:09     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup.js | denylist entry resource://gre/modules/FxAccounts.jsm for phase "before handling user events" must exist - 

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bfc49a5b518
Check that denylist/intermittent files actually exist in startup perf tests. r=florian

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6bfc49a5b518