1777892 - New JS POP3 implementation no longer logs received messages in the activity manager

Status: RESOLVED FIXED

(MailNews Core :: General, defect)

Description

[Rachel Martin]

This was implemented in bug 1211261 comment #45 and no longer works.

The code from
https://hg.mozilla.org/comm-central/rev/7abe3eb0e95845e5ce52f3639cc65832725fe726
is still there, with a slight variation from here:
https://searchfox.org/comm-central/search?q=msgUnincorporatedMoved&path=&case=false&regexp=false
https://hg.mozilla.org/comm-central/rev/31e99dd7762a

Alice, could you please check where this went broken, maybe in bug 1685484, although that would have been tested.

STR: Set up a POP3 account and send yourself a message. It should show up in the activity manager (as you can see in bug 1211261 comment #45).

Comment 1

[Rachel Martin]

Still working with the C++ POP3 module. No regression search necessary.

Comment 2

[Ping Chen [:rnons] (away)]

Attachment: Bug 1777892 - Notify activity manager when pop3 messages downloaded. r=#thunderbird-reviewers

Comment 3

[Rachel Martin]

Thanks, the patch restores the listing of the count of downloaded messages in the Activity Manager.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/818289b8740d
Notify activity manager when pop3 messages downloaded. r=#thunderbird-reviewers,darktrojan

Comment 5

[Ping Chen [:rnons] (away)]

Comment on attachment 9284276 [details]
Bug 1777892 - Notify activity manager when pop3 messages downloaded. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1707548
User impact if declined: POP3 message downloaded/moved is not shown in the activity manager
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9284276 [details]
Bug 1777892 - Notify activity manager when pop3 messages downloaded. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 103.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/c57b8bb53d2b

Comment 8

[Ping Chen [:rnons] (away)]

Comment on attachment 9284276 [details]
Bug 1777892 - Notify activity manager when pop3 messages downloaded. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1707548
User impact if declined: POP3 message downloaded/moved is not shown in the activity manager
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9284276 [details]
Bug 1777892 - Notify activity manager when pop3 messages downloaded. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 102.1.0:
https://hg.mozilla.org/releases/comm-esr102/rev/6bc7e73d65a9