1777914 - IDBTransaction::AbortInternal doesn't send the abort message when needed

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect, P2)

Description

[Jan Varga [:janv]]

This is a regression introduced by bug 1598164. Especially by these two patches:
https://phabricator.services.mozilla.com/D54322
https://phabricator.services.mozilla.com/D55142

There's a code comment which describes the case when the messages needs to be sent:

  // Fire the abort event if there are no outstanding requests. Otherwise the
  // abort event will be fired when all outstanding requests finish.

I believe mReadyState should have been removed from the check.

This regression has been discovered while we were debugging bug 1775241.

We think that many existing intermittent failures are caused by this issue and probably some shutdown hangs as well.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1777914 - IDBTransaction::AbortInternal doesn't send the abort message when needed; r=#dom-storage

Comment 2

[Jan Varga [:janv]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0e27c8043f13d9ade84c249fa7c41ad7d08d021

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1598164

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/10fdd5989d07

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:janv, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox103 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Jan Varga [:janv]]

Comment on attachment 9283983 [details]
Bug 1777914 - IDBTransaction::AbortInternal doesn't send the abort message when needed; r=#dom-storage

Beta/Release Uplift Approval Request

• User impact if declined: Higher probability of experiencing shutdown hangs.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a simple change and the fix has been thoroughly tested.
• String changes made/needed: None
• Is Android affected?: Unknown

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9283983 [details]
Bug 1777914 - IDBTransaction::AbortInternal doesn't send the abort message when needed; r=#dom-storage

Approved for 103.0b6, thanks.

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/24c3a7c835ae