Closed Bug 1777924 Opened 2 years ago Closed 2 years ago

update_remote_settings_records.mjs fails with Node 16

Categories

(DevTools :: Inspector: Compatibility, defect, P3)

defect

Tracking

(firefox104 fixed)

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

Details

Attachments

(1 file)

Tried to run SERVER=stage AUTH='XXX' yarn update-rs-records with Node 16+ and had a bunch of errors related to the import of a json module. Per https://github.com/mdn/browser-compat-data, we can use the data in 2 ways:

// ESM with Import Assertions (NodeJS 16+)
import bcd from '@mdn/browser-compat-data' assert { type: 'json' };

// ...or...

// ESM Wrapper for older NodeJS versions (NodeJS v12+)
import bcd from '@mdn/browser-compat-data/forLegacyNode';

Right now we are using a third, undocumented way: import bcd from '@mdn/browser-compat-data'. This seems to work "fine" for Node < 16 but breaks for Node 16+.
Unless we expect all peers to use Node 16+ we should switch to the legacy wrapper import bcd from '@mdn/browser-compat-data/forLegacyNode';

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: