1777964 - [wpt-sync] Sync PR 34690 - Reland "Reland "CSS highlight painting: bump HighlightOverlayPainting to stable""

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 34690 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34690
Details from upstream follow.

Delan Azabani <[e-mail]> wrote:

Reland "Reland "CSS highlight painting: bump HighlightOverlayPainting to stable""

This is a reland of commit 387b61732a4ca2f25d7aa5b376de0d373e4e72c2

Original change's description:

Reland "CSS highlight painting: bump HighlightOverlayPainting to stable"

This is a reland of commit abc6f616c7bc2c53cc9d8c44b82384d43dd77d02

Original change's description:

CSS highlight painting: bump HighlightOverlayPainting to stable

This patch enables the new highlight overlay painter. The rebaselined
tests and their reasons are as follows:

• no more double painting bug
• dark-mode/colors/selection.html
• originating decorations are now recolored per spec
• editing/selection/line-wrap-2.html
• virtual/text-antialias/selection/khmer-selection.html
• spelling markers are now consistently painted over text
• paint/markers/document-markers-font-8px.html
• paint/markers/document-markers-zoom-2000.html
• decorations are now clipped to highlight background rect
• svg/text/text-selection-deco-01-b.svg
• svg/text/text-selection-text-03-b.svg

The only new failure expectations are as follows:

• external/wpt/css/css-pseudo/highlight-painting-003.html broadens
from Mac11 to Mac (like we had to do in CL:3608432)
• external/wpt/css/css-text-decor/text-decoration-color-selection-001
fails because the test is incorrect (bug 1321106)
• paint/markers/suggestion-marker-basic.html fails because it’s not
clear the assertion still complies with the spec (bug 1321114)

Some tests had bugs that we’ve fixed in this patch:

• external/wpt/css/css-pseudo/target-text-text-decoration-001.html
had a bug where it assumed UA default highlight colors would be
suppressed by an author ‘text-decoration’

Bug: 1147859
Change-Id: Ie4d8dae515a786fa01e8f2852d645f3a8ad313be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3616170
Reviewed-by: Stephen Chenney \<[e-mail]>
Commit-Queue: Delan Azabani \<[e-mail]>
Reviewed-by: Koji Ishii \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1001604}

Bug: 1147859
Change-Id: Icd150ff8c695d20a5c9f44df45d5e0751c31f79a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3640642
Reviewed-by: Koji Ishii \<[e-mail]>
Commit-Queue: Delan Azabani \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1001937}

Bug: 1147859
Change-Id: I42ea7d56b029e933cfae12bf12c17d4bb46ffbc8
Reviewed-on: https://chromium-review.googlesource.com/3739907
WPT-Export-Revision: 6cbfb1a8f0365997f9eb679826f2977830c2d1f4

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=eee4b5fa334be2579588fc154b448dfe55b8cbf5

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3dcad98f3279
[wpt PR 34690] - Reland "Reland "CSS highlight painting: bump HighlightOverlayPainting to stable"", a=testonly

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/3dcad98f3279