1777981 - "Delete cookies and site data when Firefox is closed" no longer checked when "Always use private browsing mode" is enabled

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Ina Popescu, Desktop QA]

Note

• Please use a new profile to reproduce this bug.

Found in

• Firefox 103.0b4

Affected versions

• Firefox 103.0b4
• Nightly 104.0a1

Affected platforms

• Windows 10
• Ubuntu 22
• macOS 12

Steps to reproduce

1. Launch Firefox and go to "about:preferences#privacy"
2. Select "Use custom settings for history" option from the History dropdown list
3. Check the "Always use private browsing mode" checkbox
4. Click on the "Restart Firefox now" button in the confirmation popup

Expected result

• The "Delete cookies and site data when Firefox is closed" checkbox from the Cookies and Site Data section is displayed as checked and locked.

Actual result

• The "Delete cookies and site data when Firefox is closed" checkbox from the Cookies and Site Data section appears unchecked and locked.

Regression range

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5da87985517e8368a61a32ade7e5eab38e3f5770&tochange=cda9c3f8950b0fcb826af8f7c0516275c8c0f7b2

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:epopescu, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 3

[Hannah Peuckmann]

This looks more like a regression of Bug 1681495. There is no need for a fresh profile to reproduce this bug. The checkbox just keeps the state it had before PB mode.
The Idea behind the bug that caused this was to sync the "Delete cookie and site data" and the "Clear history when Firefox closes" check boxes because they are setting the same preferences.
I am talking to Paul whether we should have those checkboxes synced in PB mode as well (unchecked), or if we want to keep the original behavior and always have the "Delete cookie and site data" box checked in PB mode.

Comment 4

[Hannah Peuckmann]

Attachment: Bug 1777981 - DeleteOnClose box always checked in pb autostart mode. r=pbz!

Comment 5

[Donal Meehan [:dmeehan]]

:hpeuckmann
I see you just added a patch but I was wondering about the timing for this bug.
We are preparing 103 RC.
Can this ride the trains with 104 or does it need to go out in 103? (either a dot release or if there's an RC respin)

Comment 6

[Hannah Peuckmann]

(In reply to Donal Meehan [:dmeehan] from comment #5)

:hpeuckmann
I see you just added a patch but I was wondering about the timing for this bug.
We are preparing 103 RC.
Can this ride the trains with 104 or does it need to go out in 103? (either a dot release or if there's an RC respin)

Thank you for having an eye on this. This can go with 104. It really is 'just' an UI issue, meaning, it is not breaking any PB mode/ sanitization behavior.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46d235523589
DeleteOnClose box always checked in pb autostart mode. r=pbz

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/46d235523589

Comment 9

[Ina Popescu, Desktop QA]

Reproduced the issue with Firefox 103.0b4 on Windows 10x64.
The issue is verified fixed with Firefox 104.0b6 on Windows 10x64, macOS 12 and Ubuntu 22.04. The "Delete cookies and site data when Firefox is closed" checkbox from the Cookies and Site Data section is shown as checked and locked.