Closed
Bug 1778038
Opened 2 years ago
Closed 2 years ago
Use seek target as a threshold when requesting data during seeking
Categories
(Core :: Audio/Video: Playback, task, P2)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
105 Branch
| Tracking | Status | |
|---|---|---|
| firefox105 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Here we use mCurrentPosition as a threshold when requesting a video data. However, during seeking, mCurrentPosition might have not been updated yet, which causes video frozen because of using incorrect time as a threshold.
|
Assignee | |
Comment 1•2 years ago
|
||
video data.
During seeking, the current position might still be the wrong value and
hasn't been updated yet. Therefore, we should use the time of seek
target in order to avoid incorrectly discarding video frame due to the
wrong threshold time.
|
||
Updated•2 years ago
|
Attachment #9284074 -
Attachment description: Bug 1778038 - use seek target's time as a threshold when requesting a → Bug 1778038 - use seek target's time as a threshold when requesting a video data.
|
|
||
Updated•2 years ago
|
Attachment #9284074 -
Attachment description: Bug 1778038 - use seek target's time as a threshold when requesting a video data. → WIP: Bug 1778038 - use seek target's time as a threshold when requesting a video data.
|
|
||
Updated•2 years ago
|
Attachment #9284074 -
Attachment description: WIP: Bug 1778038 - use seek target's time as a threshold when requesting a video data. → WIP: Bug 1778038 - part1 : use seek target's time as a threshold when requesting a video data.
|
|
Assignee | |
Comment 2•2 years ago
|
||
We should request new data after finishing seeking, otherwise it would
send incorrect data to the remote media engine.
Depends on D150988
|
|
||
Updated•2 years ago
|
Attachment #9285073 -
Attachment description: WIP: Bug 1778038 - part2 : don't request new data during seeking. → WIP: Bug 1778038 - part2 : reply engine data request after finishing reader seek.
|
|
||
Updated•2 years ago
|
Attachment #9284074 -
Attachment description: WIP: Bug 1778038 - part1 : use seek target's time as a threshold when requesting a video data. → Bug 1778038 - part1 : use seek target's time as a threshold when requesting a video data. r=jolin
|
|
||
Updated•2 years ago
|
Attachment #9285073 -
Attachment description: WIP: Bug 1778038 - part2 : reply engine data request after finishing reader seek. → Bug 1778038 - part2 : reply engine data request after finishing reader seek. r=jolin
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d3977a3e0d07 part1 : use seek target's time as a threshold when requesting a video data. r=jolin https://hg.mozilla.org/integration/autoland/rev/47a11fe4fd7b part2 : reply engine data request after finishing reader seek. r=jolin
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d3977a3e0d07
https://hg.mozilla.org/mozilla-central/rev/47a11fe4fd7b
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox105:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•