1778075 - [wpt-sync] Sync PR 34701 - Move tests asserting awaitPromise from evaluate.py to await_promise.py

Status: RESOLVED FIXED

(Testing :: geckodriver, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 34701 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34701
Details from upstream follow.

Julian Descottes <[e-mail]> wrote:

Move tests asserting awaitPromise from evaluate.py to await_promise.py

This was originally discussed and developed at https://phabricator.services.mozilla.com/D150467
Moving it to GitHub to get feedback from @sadym-chromium

For some context, we added await_promise.py in https://phabricator.services.mozilla.com/D149924 which ended up landing in m-c. So feel free to also give feedback about the tests in await_promise.py here since we didn't have a chance to do the review on GitHub for those.

Otherwise the idea here is simply to keep most tests related to await_promise in the same file. This doesn't add any new test, we are only moving and renaming existing ones. We have a similar change for handling errors currently at https://phabricator.services.mozilla.com/D150246 which will most likely end up as another PR here.

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e423eb662d4d41c9f92d4257134e20481d027f1

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 4 subtests

Status Summary

Firefox

OK : 2
PASS : 20[GitHub] 21[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt]
FAIL : 4[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 5[GitHub]

Chrome

TIMEOUT: 2

Safari

OK : 2
ERROR : 25

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webdriver/tests/bidi/script/evaluate/await_promise.py [wpt.fyi]
  • test_await_promise_rejected: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Safari: ERROR)
  • test_no_await_promise_rejected: FAIL (Safari: ERROR)
  • test_no_await_promise_resolved: FAIL (Safari: ERROR)
• /webdriver/tests/bidi/script/evaluate/evaluate.py [wpt.fyi]
  • test_params_expression_invalid_script: FAIL (Safari: ERROR)
  • test_exception: FAIL (Safari: ERROR)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47d870aee424
[wpt PR 34701] - Move tests asserting awaitPromise from evaluate.py to await_promise.py, a=testonly
https://hg.mozilla.org/integration/autoland/rev/9dec233b6936
[wpt PR 34701] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/47d870aee424
https://hg.mozilla.org/mozilla-central/rev/9dec233b6936